Giter Club home page Giter Club logo

Comments (4)

ACEnglish avatar ACEnglish commented on June 16, 2024

Thank you so much for reporting this. Indeed there was a problem with the ordering. I was returning a bool instead of int for my functools.cmp_to_key functions. Develop now has a fix if you'd like to test using that. This is a big enough problem that I'll try to cut an official v3.3 release soon

from truvari.

jxcao98 avatar jxcao98 commented on June 16, 2024

Thank you for your quick reply! So no matter how the parameters are set, is the first row kept by default?
By the way, I noticed overlapped SVs in the same sample were reported occasionally by some SV detection software (for example, Manta). For cohort-level VCF, re-genotyped after merging all individuals may also introduce overlapping SVs in the same sample.
Have you ever had similar issues and do you have any recommendations for solutions?

from truvari.

ACEnglish avatar ACEnglish commented on June 16, 2024

I believe with v3.2 the first variant was always kept regardless of --keep. However, the fix for this also exposed that there was a lack of enforced determinism in the sorting. So the safest assumption is that it was just randomly picking a variant. I also just put in dbdbe55 which will help collapse more consistently choose alleles.

I think it would take a long time to fully answer your question - it is a complex subject, to say the least. But, I can point you to our preprint where one of the things we try to show is that there is more allelic diversity than other SV merging tools report. The point being that I have observed overlapping SVs and believe in being cautious about over-merging.

from truvari.

jxcao98 avatar jxcao98 commented on June 16, 2024

Interesting research! Thanks again for the useful tool!

from truvari.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.