accessiblefuture / braille Goto Github PK

Hi! I'm the one who reviewed and approved your plugin on WordPress.org. While there weren't any blocking issues, I found a few things you'll likely want to improve on the next round of work:

• You'll want to make sure you properly sanitize all of your form values. This helps protect WordPress from any malicious or incorrect input. Here's a good document on the subject: http://make.wordpress.org/docs/plugin-developer-handbook/plugin-security/securing-input/
• Rather than checking whether Anthologize is an active plugin, you might instead check whether function_exists( 'anthologize_register_format_option' ). There's a little less overhead in the latter approach.
• Furthermore, with your Anthologize check, you'll want to hook it into an action like 'init' or 'plugins_loaded'. Currently, your code is depending on WordPress simply loading Anthologize before your plugin.
• Instead of using cURL, you might consider using the WP HTTP API for remote requests. Functions like wp_remote_get() use the best available transport mechanism for the server, let it be file_get_contents(), cURL, etc.

Hope this helps.