Giter Club home page Giter Club logo

ess's People

Contributors

acaloiaro avatar actions-user avatar meatcar avatar mehulgohil avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ess's Issues

Hash mismatch when running ess through nix

$ nix run github:acaloiaro/ess
error: hash mismatch in fixed-output derivation '/nix/store/58i7x5rjiiqyzc1h1p7ailkh8yni3nfv-ess-20231009-go-modules.drv':
         specified: sha256-Nxx88tK4bNg4kMXjamJZZLxWs/zPkI9Ukp9ATaBxo5o=
            got:    sha256-nnJCCKzlKIZmNBSrX9FejDHCvhSdChepQU9Pl0hbIaw=
error: 1 dependencies of derivation '/nix/store/92bd1fsq73vn7xj0kk931afvxfacfp1y-ess-20231009.drv' failed to build

Looks like e46d3e4 set an incorrect hash?

Using https://github.com/nix-community/gomod2nix to pin vendor versions directly would eliminate the need for vendorSha256. I can throw together a PR if you'd like.

direnv support

Currently, this hook only supports .env files with environment variables of the form VAR_NAME=VAR_VALUE. Direnv-style .envrc is not currently supported. Pull requests welcome!

Hi, cool project. I thought I would chime in since I'm the author of direnv.

The .envrc format is full bash, so it will be difficult to support. But you can tell direnv users to use the dotenv stdlib function to load the .env file, and become compatible with this project. It's one more file in the repo but I think it's worth it.

Don't require overwrite of existing pre-commit hooks

When running env-sample-sync install, if a git pre-commit hook is already installed, env-sample-sync gives the user the option (yes/no) to overwrite the existing one. This is not ideal because the user should have the option to retain any existing pre-commit hooks. This should be relatively easy to fix.

The way env-sample-sync install works is by installing the hook to .git/hooks/pre-commit.

  1. Checks whether a hook is already installed and provides an option to overwrite the existing one
  2. Creates a directory named pre-commit-hooks.d
  3. Makes a copy of itself (the binary) and places it in pre-commit-hooks.d
  4. Writes its own pre-commit bash script to .git/hooks/pre-commit
    4.1 This script executes all executables in pre-commit-hooks.d.

To make the changes for this issue, between (2.) and (3.), add a step to copy any existing pre-commit script into pre-commit-hooks.d before writing env-sample-sync's pre-commit script.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.