CMake does not generate "toFloat.h" with Ninja about openexr HOT 10 CLOSED

@ZeroCrunch @francis-brissette This fix is on the develop branch, thanks Jamie!

from openexr.

Is there a way to manually generate all the needed files?

from openexr.

I figure it out. Still a workaround, though.

cd IlmBase/Half/
g++ eLut.cpp -o eLut && ./eLut > eLut.h
g++ toFloat.cpp -o toFloat && ./toFloat > toFloat.h
*compile IlmBase*
cd OpenEXR/IlmImf/
g++ b44ExpLogTable.cpp -o b44ExpLogTable -pthread -I../../IlmBase/Half/ ../../IlmBase/Half/libHalf.a ../../IlmBase/Iex/libIex-2_1.a ../../IlmBase/IlmThread/libIlmThread-2_1.a
./b44ExpLogTable > b44ExpLogTable.h
./b44ExpLogTable > ../b44ExpLogTable.h

from openexr.

I have the same issue with Ninja on Window:

cd openexr\IlmBase
mkdir build
cd build
cmake .. -G Ninja
cmake --build .

Output:
ninja: error: 'Half/toFloat.h', needed by 'Half/CMakeFiles/Half.dir/half.cpp.obj', missing and no known rule to make it

Anyone have a fix?

from openexr.

Anyone managed to get this working?

from openexr.

@ZeroCrunch ,

In openexr/IlmBase/Half/CMakeLists.txt, I updated the code to the followin:g:

...
SET_SOURCE_FILES_PROPERTIES(
  half.cpp
  PROPERTIES
  OBJECT_DEPENDS
  toFloat
  OBJECT_DEPENDS
  eLut
  )

IF(BUILD_SHARED_LIBS)
    ADD_DEFINITIONS(-DHALF_EXPORTS)
ENDIF()

ADD_LIBRARY ( Half ${LIB_TYPE}
  half.cpp
  )

INSTALL ( TARGETS
  Half
  DESTINATION
  lib
)
...

It worked on my side.

Cheers,
Francis

from openexr.

This looks like the correct fix to me - it would be a good PR.

from openexr.

@francis-brissette,

What worked for me in the end was:

PROPERTIES
OBJECT_DEPENDS
"${CMAKE_CURRENT_BINARY_DIR}/toFloat.h;${CMAKE_CURRENT_BINARY_DIR}/eLut.h"

from openexr.

@meshula, will you take care of this bug & fix?

from openexr.

Looking into the backlog of open OpenEXR issues. This seems to have been resolved in the v2.3.0 release.
Closing the issue for now, feel free to re-open or file a new issue if you need further help.

from openexr.