Incorrect Values When Reading DWA Compressed Layer With OpenEXRCore about openexr HOT 10 CLOSED

In the meantime I'm back-patching myself so we can confirm that it fixes the original problem in the wild.

Can confirm that this in conjunction with #1591 do fix the original problem in Gaffer. Thanks once again!

from openexr.

This also seems to work without a prefix, (i.e. just saving as R,G,B instead of albedo.{R,G,B}, which says the bug is in the channel name classifier logic for DWA. Will investigate more

from openexr.

Thanks for looking at this so quickly @kdt3rd. We've updated to OpenEXRCore for Gaffer 1.4, and in conjunction with some threading improvements we've made, we're seeing a 3-4x speedup in image loading. So we're definitely fans. Gaffer 1.4 is currently in beta, with the goal being to make an official release in the first half of April. Do you think this could be fixable in that timeframe, including being backported to the 3.1.x branch? We could obviously fall back to the old non-core code path as a last resort, but now we've seen the shiny new performance we're very reluctant to let it go :)

from openexr.

Will check with the others, but don't see why it can't be backpatched, it is a one-line fix. I am not sure if there have been other fixes since (I feel like so, but maybe we already back-patched those). Glad you're seeing benefit!

from openexr.

Oh, that simple! Thanks for the quick fix! Worst case, we can just apply that patch ourselves when we build OpenEXR.

from openexr.

It looks like we would also need #1591 to be back-ported to the 3.1.x branch if we're to rely on OpenEXRCore. Does OpenEXR have a policy regarding which versions are patched? Although it is 2024, we're sticking to VFXPlatform 2023 for Gaffer 1.4 because in practice that serves our users better (they're using other apps which also aren't 2024 compatible).

from openexr.

Stated policy is here: https://github.com/AcademySoftwareFoundation/openexr/blob/main/SECURITY.md#supported-versions

These are simple fixes, we'll back-port them to 3.1, hopefully in the next few days.

from openexr.

Thanks @cary-ilm - that's great. In the meantime I'm back-patching myself so we can confirm that it fixes the original problem in the wild.

from openexr.

This fix is now released in v3.2.4 and backported to v3.1.13.

from openexr.

Thanks @cary-ilm!

from openexr.