Graph fails on name conflicts across namespaces about materialx HOT 4 OPEN

Hi @dgovil ,
This is considered a valid graph (i.e. unique naming within the "namespace" / graph level) so it seems it's more a problem with logic for code generation and vote to fix that. There are existing unique name matching issues before so adding @niklasharrysson in.

from materialx.

That's good to know, thanks. I edited the issue title accordingly.

from materialx.

Hey @niklasharrysson ,

I looked at the code a bit and it's the same issue we've discussed before -- that of lack of appropriate ShaderGraph context when dealing with nodegraphs . i.e. all ShaderNodes are in the same ShaderGraph. So the node name map will encounter the same node name more than once -- resulting in the symptom encountered here

 // We have a node downstream
        ShaderNode* downstream = getNode(downstreamNode->getName());
        if (downstream && connectingElement)
        {
            ShaderInput* input = downstream->getInput(connectingElement->getName());
            if (!input)
            {
                throw ExceptionShaderGenError("Could not find an input named '" + connectingElement->getName() +
                                              "' on downstream node '" + downstream->getName() + "'");
            }
            input->makeConnection(output);
        }

getNode() looks up by name which is not unique.

from materialx.

Hey @kwokcb , thanks for investigating. And yes, this will be resolved when we get to updating the ShaderGraph to keep all graph hierarchies.

from materialx.