Giter Club home page Giter Club logo

critical-css-parser's People

Contributors

abvanton200 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

critical-css-parser's Issues

Errors, closing tags

Any tips on configuring linting rules in this bad boy? dropcss.cs.js throws error around this line:
'var TAG_OPEN = 1;'

error:

if (VOIDS.has(tag) || m2[1] == "/>")

TypeError: Cannot read property '1' of null
at next (.....\node_modules\dropcss\dist\dropcss.cjs.js:70:28)
at tokenize (.....\node_modules\dropcss\dist\dropcss.cjs.js:87:3)
at export_parse .....\node_modules\dropcss\dist\dropcss.cjs.js:195:15)
at dropcss (.....\node_modules\dropcss\dist\dropcss.cjs.js:969:10)
at n (.....\node_modules\critical-css-parser\dist\index.modern.js:1:2055)
at module.exports (.....\node_modules\critical-css-parser\dist\index.modern.js:1:3197)
at async module.exports (.....\node_modules\critical-css-inliner\dist\index.modern.js:1:512)
at async .\critical_css_inliner.js:5:3

'critical_css_inliner.js is script it's running from, same error with critical-css-parser and critical_css_inliner

it's possible to remove necessary css and break above-the-fold

@ABVanton200

#card {
  position: absolute;
  top: 1000%;
}

this will probably remove this #card element, then drop its CSS and on the real page it will now (wrongly) appear above the fold.

i can't think of a solution to this. but you may want to mention that stuff like this can happen if elements are moved below the fold by css only.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.