abodhassam / hyf-homework Goto Github PK

Hey Abod...
I am going to give you some feedback:
First of, it looks super good! Good job on doing the homework.
HTML
Understand the difference between classes and id's: https://dev.to/claireparker/reasons-not-to-use-ids-in-css-4ni4 We rarely use id's in html.
Look into html5 tags.
Try avoiding tables, they are very difficult to work with responsively.
For your email, address and telephone add a link to the, using fx href="tel:123" or href="mailto:123"
Line 12 you have a section with the name section1, give the classes semantic names that describe the content. Section1 does not say anything about the content.
Make things that conceptually are lists into either ul or ol tag. Fx with education you have a list of educations. The same with references, experiences and skills
Line 129 you have used the nav tag, but that is for navigation within the pages with links etc.
CSS
Really nice and well structured. Some good selectors aswell! Event some pseudoelements, nice! Dont really have any feedback for that part.
Nicely done Abod :)