Giter Club home page Giter Club logo

gosmopolitan's Introduction

gosmopolitan

GitHub Workflow Status (main branch) Codecov GitHub license info GitHub go.mod Go version Go Report Card Go Reference

简体中文

gosmopolitan checks your Go codebase for code smells that may prove to be hindrance to internationalization ("i18n") and/or localization ("l10n").

The name is a wordplay on "cosmopolitan".

Checks

Currently gosmopolitan checks for the following anti-patterns:

  • Occurrences of string literals containing characters from certain writing systems.

    Existence of such strings often means the relevant logic is hard to internationalize, or at least, require special care when doing i18n/l10n.

  • Usages of time.Local.

    An internationalized app or library should almost never process time and date values in the timezone in which it is running; instead one should use the respective user preference, or the timezone as dictated by the domain logic.

Note that local times are produced in a lot more ways than via direct casts to time.Local alone, such as:

  • time.LoadLocation("Local")
  • received from a time.Ticker
  • functions explicitly documented to return local times
    • time.Now()
    • time.Unix()
    • time.UnixMilli()
    • time.UnixMicro()

Proper identification of these use cases require a fairly complete dataflow analysis pass, which is not implemented currently. In addition, right now you have to pay close attention to externally-provided time values (such as from your framework like Gin or gRPC) as they are not properly tracked either.

Caveats

Note that the checks implemented here are only suitable for codebases with the following characteristics, and may not suit your particular project's needs:

  • Originally developed for an audience using non-Latin writing system(s),
  • Returns bare strings intended for humans containing such non-Latin characters, and
  • May occasionally (or frequently) refer to the local timezone.

For example, the lints may prove valuable if you're revamping a web service originally targetting the Chinese market (hence producing strings with Chinese characters all over the place) to be more i18n-aware. Conversely, if you want to identify some of the i18n-naïve places in an English-only app, the linter will output nothing.

golangci-lint integration

gosmopolitan is not integrated into golangci-lint yet, but you can nevertheless run it as a custom plugin.

First make yourself a plugin .so file like this:

// compile this with something like `go build -buildmode=plugin`

package main

import (
	"github.com/xen0n/gosmopolitan"
	"golang.org/x/tools/go/analysis"
)

type analyzerPlugin struct{}

func (analyzerPlugin) GetAnalyzers() []*analysis.Analyzer {
	// You can customize the options via gosmopolitan.NewAnalyzerWithConfig
	// instead.
	return []*analysis.Analyzer{
		gosmopolitan.DefaultAnalyzer,
	}
}

var AnalyzerPlugin analyzerPlugin

You just need to make sure the golang.org/x/tools version used to build the plugin is consistent with that of your golangci-lint binary. (Of course the golangci-lint binary should be built with plugin support enabled too; notably, the Homebrew golangci-lint is built without plugin support, so beware of this.)

golangci-lint version gosmopolitan tag to use
1.50.x v1.0.0

Then reference it in your .golangci.yml, and enable it in the linters section:

linters:
  # ...
  enable:
    # ...
    - gosmopolitan
    # ...

linters-settings:
  custom:
    gosmopolitan:
      path: 'path/to/your/plugin.so'
      description: 'Report certain i18n/l10n anti-patterns in your Go codebase'
      original-url: 'https://github.com/xen0n/gosmopolitan'
  # ...

Then you can golangci-lint run and //nolint:gosmopolitan as you would with any other supported linter.

License

gosmopolitan is licensed under the GPL license, version 3 or later.

gosmopolitan's People

Contributors

xen0n avatar dependabot[bot] avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.