Giter Club home page Giter Club logo

ad-free's People

Contributors

abertschi avatar bennettscience avatar inktrap avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ad-free's Issues

After 1.0, activates on all songs

I'm running Android 6.0.1. I have tried it with Spotify 8.5.36.747 and the beta 8.5.39.234. It activates as soon as I start playing music on Spotify and will not stop. I tried upgrading to 1.2.1 to see if it worked, as I have been downgrading back to 1.0 each time. I did not keep a copy of the apk, and now it is removed from F-Droid. Is there a way to remedy this or downgrade back to 1.0, so I can use the app? Edit: I have found a copy of the apk from F-Droid's website on the Wayback Machine, which again, does function as expected. Is there any reason why 1.0 works but newer versions do not?

No Ads Blocked

I'm on an A501DL running Android 8.1.0 and I have no indication the app is doing anything, even on logcat. Spotify plays all the ads, showing a distinctive notification for them too. I tried the music note button in the app, and it will silence the playback when I ask, it just doesn't do it on its own.

Improve F-Droid listing

I've seen this app on F-Droid, but it lacks screenshots, changelog and a translatable description there. It's pretty easy for you to add these information. Please have a look at this example or at the F-Droid docs or fastlane docs.
After you have commited these files to your repo and tagged a new version, you need to remove the Description and Summary from the metadata file in the F-Droid Data repo.

Ads back on on Volume up during interdimensional cable

-One Plus 7 Pro
-Oxygen OS 9.5.11 (Android 9.x port)
-Phone is connected to bluetooth speaker/headset.
-Interdimensinal cabel setting

On changing volume it also changes the mute setting for ads:

--->I can hear spotify ads as well as interdimensional cable

to reproduce:

turn on interdimensional cable
listen to spotify and wait for ads
turn volume louder -->ads and interdimensional cable plays simultaneously

Note; This setting is also saved, so next time ads show up it still plays simultaneously

Temporary fix:

  • turn off spotify,
  • open ad-free
  • re-apply the setting

add option to play radio or podcast

When there is an add just play a radio choose by the user. It is just a proposal, I haven't think about the technical part or the use by the many.

Unmutes a few seconds too early, playing endings of ads.

Using Essential phone PH-1, using latest version of Spotify and Ad-Free. Most of the time, the phone would unmute before the ad finishes so a few seconds of ads would be played. Is there any way to unmute at the right time? Even just extend a few more seconds to mute the music would be less distracting.

Interdimentional cable only plays during the 1st ad.

OnePlus One
Lineage 15

Spotify started recently to push multiple ads back to back, Most often than not the exact same ad is played twice, that's what motivated me to look for a fix.
While ad-free does a great job, only one clip of Interdimentional Cable (IC) is played and then mute. Is there a way you could loop the IC while the ads finish playing?

Regardless thanks a lot for your work

SoundCloud app support

Very nice app. Do you plan to support muting SoundCloud ads? Their notifications have the same title and text for different ads.

Bluetooth Headset Error

I tried to use the app (F-Droid Version 2.2/36 )on my OnePlus5 (Android 9) with JBL Bluetooth headphones but when the app detected advertise it muted everything instead of playing local music. But with wired headphones all worked well.

I was able to get things work when disabling the last option in following screenshot (sorry only in German)

Perhaps it would be great for other users to add this into the troubleshooting site.

The app is very great, I enjoy listening music, thank you very much!

add update reminder

the app is currently mostly distributed via fdroid store. however there is an option to download it manually via github. fdroid builds and signs this app themselves in order to deploy it to their store.

  • find out if app was built by fdroid or not (check signature)
  • if not signed by fdroid, check for new releases on this site and provide a download link on update

Completely non-working on Fire OS (5.6.0.1)

Possibly out of scope, obviously.

Fire OS is the customized version of Android used on Amazon "Fire" devices (most notably tablets). The current version is based on Android 5.1.1 Lollipop. Broadly, standard Android app compatibility is good on Fire OS. It's possible to sideload F-Droid and install other apps than those explicitly intended for Fire OS.

However, Ad-Free doesn't seem to work at all on this setup. There's no notification to ensure activity is maintained and Spotify ads are not in any way affected by the app running. The mechanism by which similar apps function seems to do the job on Fire OS: the app "Spotify Admodify" similarly triggers its own notification then monitors Spotify notifications and is able to mute its ads without issue.

Ad detection

How is it done. By notification bar right?. If so, how is it detected, what is used. How can I do this myself.

Thanks in advance

ad-free muting every new music track

On android 9 (pie) every new audio track played by Spotify 5.5.0.653 is muted. Sometimes it even mutes somewhere in an audio track. It's sad to see, that ad-free became useless after summer 2019.

Remove "full network access"-permission

What does Ad-Free need full network access for? I guess it has been added in order to download the music file of Interdimensional Cable but this feature has been discontinued.

Since As-Free has full access to notifications, it could technically (!) upload user notifications somewhere (yes, it's open source and in F-Droid). I truly believe that it doesn't, but if this permission is not necessarily needed, it should be removed.

Also, for what does the app need "view network connections" and "read the contents of your shared storage" permissions?

Doesn't always unmute after an ad.

I use this app with both Spotify and Spotify Stations. It works on both.

HOWEVER, sometimes, on Bluetooth, it doesn't unmute. I think that the Bluetooth device is lagging the volume up rocker.

A potential fix is to make an option for slowly fading the music track in. Maybe a 'FX' option list would work, where I could set how fast the fade happened. Right now, I have my phone set to maximum volume, and my speaker is adjusted accordingly. I'm going to mess with the developer options and see if changing the absolute volume function fixes it.

create better logo

If you are good at design and want to contribute to ad-free, shout out here and create a new logo

if replacement audio file is shorter than ad, silence will fall.

Setup:

  1. download & install adfree APK
  2. create a local folder with contents of adfree-resources/*.mp3
  3. configure adfree app for:
    • local music

reproduction:

  1. play music in spotify

expected result:

  1. ads are replaced with multiple "replacement audio" files until spotify music resumes

actual results:

  1. when a single "replacement audio" track ends, there is only silence until spotify music resumes

Rewrite Notification listener

  • implement notification listener with observer pattern
  • currently, ad detection times out after 30 sec, but ad length can vary
  • introduce state to detect ad ending better

image

fix bug "Unable to add window -- token android.os.BinderProxy is not valid"

related to the file chooser view for selection of audio tracks.

Android version: 28
Device: samsung SM-G960U
App version: 33
Time: 2019-11-25-22:09:20
Root cause:
android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@99507bb is not valid; is your activity running?
at android.view.ViewRootImpl.setView(ViewRootImpl.java:1056)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:381)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93)
at android.app.Dialog.show(Dialog.java:470)
at com.github.angads25.filepicker.view.FilePickerDialog.show(FilePickerDialog.java:417)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicView.showFolderSelectionDialog(LocalMusicView.kt:98)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicPlugin.chooseDirectory(LocalMusicPlugin.kt:141)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicView$onCreate$4.onClick(LocalMusicView.kt:71)
at android.view.View.performClick(View.java:7333)
at android.widget.TextView.performClick(TextView.java:14160)
at android.view.View.performClickInternal(View.java:7299)
at android.view.View.access$3200(View.java:846)
at android.view.View$PerformClick.run(View.java:27773)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:6986)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)

Cant select music directory

Whenever I click to choose a music directory.

It always say "Whoops, error with chosen directory. Choose a different one"

Download songs to play later

A cool option would be to have the app download up to a certain amount of songs from Spotify to play later instead of the ads. You could have it replace already used songs with another song from Spotify.

"Play until end" - funny but confusing

I really like that some developers try to put some funny features into their apps. Really appreciate them making me smiling. But I don't understand "Play until end" option...

There should be two options only: "play local music file until spotify ad ends" or "play until end of music file, regardless if spotify ad already ended before".

add better support for SD cards

local-music plugin:
some devices mount storage to /storage which is not listed when mounting with / which defaults to /mnt

Interdimensional Cable

Please add an option to play full Interdimensional Cable Ads. It sounds weird when they're getting cut. I'm sure real Rick & Morty Fans won't mind.

Set up a security.md file

Currently, when clicking on the security tab in GitHub, "No security policy detected" is displayed.

To remediate, set up a SECURITY.md file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.