Comments (2)
from token-vesting-contracts.
Hi. Well that depends on how you see things. Because those functions are used to iterated vestings from the frontend. But we could have getEffectiveVestingSchedulesCountByBeneficiary. However I think this filtering should be done by the Dapp rather than in the contract directly. Since this information can be deducted off chain from the data in the contract (use boolean flags to filter effective vestings), I don't think it would be relevant to add this extra complexity in the contract. What do you think ?
Also it would break the way I compute the vesting id which are a hash of the holder address concatenated with an auto incremented index.
from token-vesting-contracts.
Related Issues (13)
- ERC20 transfer use βpayableβ address is unnecessary
- is there any article/video explaining the development process? HOT 2
- Question : what's the purpose of slicePeriodSeconds in struct VestingSchedule. HOT 1
- Non-linear Vesting HOT 2
- AutoDrop HOT 1
- Error: cannot create vesting schedule because not sufficient tokens HOT 2
- [NEED RECOMMENDATION] Main difference between OpenZeppelin VestingWallet and this project HOT 2
- Error with yarn test HOT 8
- Error with yarn coverage HOT 7
- Decimal Issues.
- Erc20 in vesting HOT 2
- for abdel.stark.eth about ru community (definatly not UA)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from token-vesting-contracts.