Giter Club home page Giter Club logo

Comments (8)

AbdelStark avatar AbdelStark commented on July 16, 2024 1

Sorry, I meant to say I did NOT install foundry 😖 Since the documentation implies that the repo can be used with hardhat without foundry. Trying with foundry now... The tests do work after running allthe foundry commands. Maybe you should specify it is necessary in the readme...

Oh ok. Yeah it should be more explicit indeed. Feel free to submit a PR if you want ;)

from token-vesting-contracts.

AbdelStark avatar AbdelStark commented on July 16, 2024 1

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

That's a good feature request. Can you please describe it in an issue ?

from token-vesting-contracts.

joelamouche avatar joelamouche commented on July 16, 2024 1

Sounds good I will make a PR and an issue later today

from token-vesting-contracts.

joelamouche avatar joelamouche commented on July 16, 2024

I have installed foundry and I am running v14.16.1

from token-vesting-contracts.

AbdelStark avatar AbdelStark commented on July 16, 2024

After running yarn, I get this error when running yarn test:

➜  token-vesting-contracts git:(main) ✗ yarn test
yarn run v1.22.10
$ npx hardhat test --logs
Error HH404: File lib/solmate/src/tokens/ERC20.sol, imported from src/TokenVesting.sol, not found.

For more info go to https://hardhat.org/HH404 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

the forge build command works for you ?

from token-vesting-contracts.

joelamouche avatar joelamouche commented on July 16, 2024

Sorry, I meant to say I did NOT install foundry 😖
Since the documentation implies that the repo can be used with hardhat without foundry.
Trying with foundry now...
The tests do work after running allthe foundry commands. Maybe you should specify it is necessary in the readme...

from token-vesting-contracts.

joelamouche avatar joelamouche commented on July 16, 2024

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

from token-vesting-contracts.

AbdelStark avatar AbdelStark commented on July 16, 2024

Sounds good I will make a PR and an issue later today

awesome thanks

from token-vesting-contracts.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.