abc-arbitrage / fixpp Goto Github PK

The Required or Optional attribute should not be at the tag level as a single tag may be used in multiple messages, being optional in one message and required in an other one.

Thus, this attribute should be at the Message level, not at the Tag level.

Frame parsing section not complete, can not have a glimps on the parsing usage.

Project is name fixpp, so it should live in Fixpp namespace instead of Fix

Like std::visit, Fix::visit could return a Result<T, ErrorKind> instead of Result<void, ErrorKind> depending on what the Visitor itself returns so that it would be possible to write something like

Fix::visit(frame, size, visitor).then(
    [=](bool handled) {
        if (handled) {
             ....
        }
    }).otherwise(Fix::ErrorKind error) {
});

Currently, the library is header only except for the StreamCursor that is currently compiled in a separate static library.

Should make it all header only

Currently, -ftemplate-depth is set to 2048, otherwise GCC fails to compile with an Internal Compiler Error.

Investigate why so much template instantiation depth is needed and try to reduce it.

Currently, get uses SFINAE to disambiguate between a single field or a repeating group. When attempting to retrieve an invalid tag for a given message, we thus get a compilation error instead of a nice and beautiful static assertion, which is not great

When the parser encounters an unknown tag, it just stops parsing and considers the frame to be invalid.

Instead of just stopping, we could a Strict property to the VisitRules that would tell the parser whether to enforce strict parsing, that is to say conforming to the specification. In non-strict mode, the parser would just ignore the invalid tag and continue parsing