ab-noori / portfolio Goto Github PK

https://github.com/ab-noori/My-Portfolio/blob/f186d0ce08e50d07bd2e8a314506ce89caccc655/styles.css#L449

• it would be better to make the cards responsive for width less than 1000px
• from mobile to desktop needs to be responsive.

Well done Abdulali Noori on your portfolio project. The project is complete and looking awesome. It rocks both on mobile and desktop versions.

The only things we suggest are:

1. there is a typo in about me section
   Desktop Version:
   

Mobile Version:

2. It would be nice if you implement accessibility on the desktop version so that people who prefer to use a keyboard or a screen reader to access the website, can access your beautiful website easily.

https://github.com/ab-noori/My-Portfolio/blob/f186d0ce08e50d07bd2e8a314506ce89caccc655/styles.css#L29

I think it would be better if you avoided using fixed width as this will make your website unresponsive.

Hi @ab-noori
Great job on applying the html and css best practices✔
I liked the way you sectioned your HTML elements and added comments. It makes it easier for a reviewer to understand your code.

I would like to address a few issues

Semantic tags

I think it would be better not to wrap the header and main tags in a div element.
Semantic tags clearly indicate the role of the content they contain.

Desktop-version responsiveness

I suggest the use of percentage widths rather than fixed widths. Fixed widths make your website unresponsive.
Here the wrapper div width:1440px makes it unresponsive to smaller widths.

Review

• You work hard and Did a very well job creating your portfolio.

• It is responsive and it looks good.

suggestion

• It would be better to use 100% width.
• Use some Color contrast on the button.
• it would be better to avoid a horizontal scroll bar at the bottom of your website.

I have been using GitHub pages since the beginning of the My-Portfolio project.
You can see the branch deployment link on each of my PR.
Below is my project deployment link from the main branch.
https://ab-noori.github.io/My-Portfolio/

(https://github.com/ab-noori/My-Portfolio/blob/f186d0ce08e50d07bd2e8a314506ce89caccc655/styles.css#L38)

• I think it would be better to make the header to be center in the view port width instead of making a fixed width for responsiveness
• design will break in between 768 and desktop pixels