Giter Club home page Giter Club logo

pokeemerald's People

Contributors

aarant avatar abaresk avatar asparaguseduardo avatar atasro2 avatar camthesaxman avatar deokishisu avatar diegoisawesome avatar dizzyeggg avatar garakmon avatar golemgalvanize avatar griffinrichards avatar huderlem avatar itskobold avatar jiangzhengwenjz avatar kermalis avatar kurausukun avatar louroboros avatar luckytyphlosion avatar melthelesbian avatar phlosioneer avatar pikalaxalt avatar revosucks avatar scnorton avatar sewef avatar sierraffinity avatar slawter666 avatar sphericalice avatar tustin2121 avatar ultima-soul avatar yenatch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

pokeemerald's Issues

[Followers] Follower stuck in tunnel

I have plenty of this fixed across my projects but I think its better to make proper issues so everybody benefits from them
If you dont have the time, I will eventually fix them once I gather some more
image

Times of day should be better

By default, the time between 4 and 7 am will return time of day day when its super dark outside
See: https://github.com/aarant/pokeemerald/blob/lighting/src/overworld.c#L1497
image

I suggest this as an alternative

u8 UpdateTimeOfDay(void) {
    s32 hours, minutes;
    RtcCalcLocalTime();
    hours = gLocalTime.hours;
    minutes = gLocalTime.minutes;

    if (hours < 6)
    {
        currentTimeBlend.time0 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.time1 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.weight = 256;
        currentTimeBlend.altWeight = 0;
        gTimeOfDay = TIME_OF_DAY_NIGHT;
        return gTimeOfDay;
    }
    else if (hours < 7)
    {
        currentTimeBlend.time0 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.time1 = TIME_OF_DAY_TWILIGHT;
        currentTimeBlend.weight = 256 - 256 * ((hours - 6) * 60 + minutes) / ((7 - 6) * 60);
        currentTimeBlend.altWeight = (256 - currentTimeBlend.weight) / 2;
        gTimeOfDay = TIME_OF_DAY_TWILIGHT;
        return gTimeOfDay;
    }
    else if (hours < 11)
    {
        currentTimeBlend.time0 = TIME_OF_DAY_TWILIGHT;
        currentTimeBlend.time1 = TIME_OF_DAY_DAY;
        currentTimeBlend.weight = 256 - 256 * ((hours - 7) * 60 + minutes) / ((11 - 7) * 60);
        currentTimeBlend.altWeight = (256 - currentTimeBlend.weight) / 2 + 128;
        gTimeOfDay = TIME_OF_DAY_TWILIGHT;
        return gTimeOfDay;
    }
    else if (hours < 17)
    {
        currentTimeBlend.time0 = TIME_OF_DAY_DAY;
        currentTimeBlend.time1 = TIME_OF_DAY_TWILIGHT;
        currentTimeBlend.weight = 256 - 256 * ((hours - 11) * 60 + minutes) / ((18 - 11) * 60);
        currentTimeBlend.altWeight = currentTimeBlend.weight / 2 + 128;
        gTimeOfDay = TIME_OF_DAY_DAY;
        return gTimeOfDay;
    }
    else if (hours < 21)
    {
        currentTimeBlend.time0 = TIME_OF_DAY_TWILIGHT;
        currentTimeBlend.time1 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.weight = 256 - 256 * ((hours - 18) * 60 + minutes) / ((22 - 18) * 60);
        currentTimeBlend.altWeight = currentTimeBlend.weight / 2;
        gTimeOfDay = TIME_OF_DAY_TWILIGHT;
        return gTimeOfDay;
    }
    else
    {
        currentTimeBlend.time0 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.time1 = TIME_OF_DAY_NIGHT;
        currentTimeBlend.weight = 256;
        currentTimeBlend.altWeight = 0;
        gTimeOfDay = TIME_OF_DAY_NIGHT;
        return gTimeOfDay;
    }
}

Would work like this:
It works like this:
0 - 6 = Night
6 - 7 = Twilight
7 - 11 = Twilight
11 - 17 = Day
17 - 21 = Twilight
12 - 0 = Night

Icon branch not building in modern

Unaligned stuff!
Fixed with:
static const u16 ALIGNED(4) sHandCursor_Pal[] = INCBIN_U16("graphics/pokemon_storage/hand_cursor.gbapal");
and
u16 ALIGNED(4) chooseBoxSwapPal[16]; // Holds dynamic palette to swap into choose box gfx

Small graphical bug from the key wheel when using the vs seeker

No idea how to properly report this, I'm sure there is something that just doesnt stay like the overworld was before using the key wheel, not sure if the text windows, blocks loaded in the bg or whatever, I will try to investigate more

mGBA_-_POKEMON_FIRE_60.4_fps_-_0.10.0_2023-11-29_16-04-56.3.1.1.mp4

Castform follower sprite is broken

Current bugs:

  • Broken gfx. This gets fixed changing const u32 gObjectEventPic_Castform[] = INCBIN_U32("graphics/object_events/pics/pokemon/castform.4bpp"); to use the COMP
  • Broken Palette. Now sure how to fix this one sorry

image

Showmonpic affected by day and night tints

image

I'm pretty sure that this is related to the follower sprite being loaded in the overworld, so they share the same palette, I think?
This was not really discovered before since this is a case that might happen in Kanto and not Hoenn.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.