aadlani / backup-manager Goto Github PK

in line 87:

weekNum=$(($archiveDay/7)) 

if archiveDay is "09" it is treated as a base-8 number which is invalid and script fails here. Solution for that is to explicitly say that it is a base-10 number.

weekNum=$(((10#$archiveDay)/7)) 

Thank you for this nice script. Some parts of it does not work for me:

1. On my system, date has no switch -v and -l
   I have to change it like this:
   YESTERDAY=$(date -dyesterday +%Y%m%d) //YYYYMMDD ;
2. TODAY=${TODAY:0:8} <= shouldn't it be TODAY=${NOW:0:8} and so on?
3. line 50: find $SNAPSHOT_DIR -type d -mindepth 1 -maxdepth 1 -exec basename {} ; |
   I get this:
   find: warning: you have specified the -mindepth option after a non-option argument -type, but options are not positional (-mindepth affects tests specified before it as well as those specified after it). Please specify options before other arguments.

$find $SNAPSHOT_DIR -mindepth 1 -maxdepth 1 -type d -exec basename {} ; | \
solves it.
4. GNU find command does not have an -E switch
5. /usr/local/bin/gpg <- not the standard path for gpg
Perhaps something like this might help:
// Setting binaries
find=/usr/bin/find
tar=/bin/tar
gpg=/usr/bin/gpg

//These are the commands we actually need for the backup
command_list=(date echo $find grep $gpg hostname sh $tar which)

// Verify that each command we use exists. if one can't be found use $PATH and make a suggestion if possible.
for command in ${command_list[@]}; do
if [ ! -x "which $command 2>&1" ]; then
echo -e "\nERROR: $command not found! "
base=basename $command
if [ "which $base 2>&1 | grep "no \basename $command in"" != "" ]; then
echo -e "ERROR: $base is not in your $PATH."
fi
exit -1
fi
done
(it is part of blinkeye's great mkstage4 script)

best regards,

nik-k