a-parhom / roundedsbe Goto Github PK

This project forked from kupiqu/sierrabreezeenhanced

A fork of SierraBreezeEnhanced with integrated corner rounding effect CornersShader (reworked version of what used to be called LightlyShaders) and shared configuration

License: GNU General Public License v3.0

Shell 0.40% C++ 84.87% CMake 2.35% GLSL 12.38%

roundedsbe's People

Contributors

Stargazers

Watchers

Forkers

sujaldev akselmo syndrizzle zijincode

roundedsbe's Issues

Can't match titlebar color with window color

My konsole is dark but its titlebar follow the global theme(light)

Enlarged appmenu button

The default appmenu hamburger button inherited from breeze is so tiny it's virtually unclickable. Consider replacing the appmenu hamburger icon with a wider button that says "menu..." That way it'll be easier to click.

Corners bug

I compiled and installed RoudnedSBe from master on newly installed KdeNeon and have some weird glitches.

Failed to match the exception on wayland

Same as SBE kupiqu#124

Breeze has fixed this:
https://invent.kde.org/plasma/breeze/-/merge_requests/267
https://invent.kde.org/plasma/breeze/-/merge_requests/269

Titlebar text flashing on change

When the titlebar text changes, for example when switching tabs in firefox, it starts flashing. But only sometimes. If I ened to give more information just ask me.

Corners shader crashes Plasma Wayland with dual-monitor setup

When I have the desktop effect enabled that rounds the bottom corners, plug in my external monitor and try to drag any app into it, both screens go black and all apps crash. This only happens on Wayland with the KWin script enabled.

I made a KDE bug report (I thought it was a KWin issue):
https://bugs.kde.org/show_bug.cgi?id=466430

When I disable the corner shader, everything works just fine. I have recompiled the latest version against Plasma 5.27.2 and the issue persists.

Do not highlight all buttons.

When you hover over a titlebar button, all the buttons get highlighted. This is very non-standard and provides bad feedback. I recommend just normally highlighting whichever button is the mouse is hovering over, instead of all the buttons.

Sierra Breeze Enhanced

Hi @a-parhom ,

Very nice work!

I don't have much free time to work on SBE, and I don't see this changing in the near future. Would you like to join or even take care of SBE from now on, instead of diverging with another fork?

I'm open to this or other suggestions you may have.

Best!

Locally integrated menus.

Consider adding the LIM functionality (menubar in titlebar) that hasn't gotten merged into upstream breeze.

https://invent.kde.org/plasma/breeze/-/merge_requests/126

install.sh script complains about not being able to find KF5 IconThemes on fedora kde

The install script fails on Fedora KDE 38 not being able to find KF5IconThemes provided by the kf5-kiconthemes-devel package.

The solution is obviously to just dnf install f5-kiconthemes-devel, perhaps add this in the Build dependencies section for fedora in README.md ?

install.sh script complains about not being able to find KF5 IconThemes on Regata OS [ based on OpenSUSE Leap 15.4]

this is fixed by installing package "kiconthemes-devel' form opensuse kdeframework5 repo.
It's my request to add this package in dependencies.

Can't blacklist Yakuake

rounding generated this unexpected corner, I tried to set Corner radius: to 0 px for window class yakuake to disable rounding, but it don't work. The Draw outline around windows option works, though.

Corners Shader: Kwin Wayland crashes when all monitors turned off

This issue is identical to another issue in the LightlyShaders repo.

I am using KDE 5.27.8 in Fedora Linux 38 and have recompiled and reinstalled LightlyShaders multiple times.

When using Corners Shader in a Wayland session, turning off both of my monitors (which means having no output) causes Kwin to crash. After that, only my primary monitor is actually usable since dragging a window to the second screen crashes Kwin once more. Only then will Kwin stay stable regardless of action until I turn off my monitors again.

Build errors - dependency of #include <kwinoffscreeneffect.h> not satisfied

In file included from /home/user/RoundedSBE/build/cornersshader/kwin4_effect_cornersshader_autogen/EWIEGA46WW/moc_cornersshader.cpp:10,
                 from /home/user/RoundedSBE/build/cornersshader/kwin4_effect_cornersshader_autogen/mocs_compilation.cpp:2:
/home/user/RoundedSBE/build/cornersshader/kwin4_effect_cornersshader_autogen/EWIEGA46WW/../../../../cornersshader/cornersshader.h:25:10: fatal error: kwinoffscreeneffect.h: No such file or directory
   25 | #include <kwinoffscreeneffect.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [cornersshader/CMakeFiles/kwin4_effect_cornersshader.dir/build.make:76: cornersshader/CMakeFiles/kwin4_effect_cornersshader.dir/kwin4_effect_cornersshader_autogen/mocs_compilation.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:848: cornersshader/CMakeFiles/kwin4_effect_cornersshader.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/home/user/RoundedSBE/breezedecoration.cpp: In member function ‘void Breeze::Decoration::updateBlur()’:
/home/user/RoundedSBE/breezedecoration.cpp:780:13: error: ‘setBlurRegion’ was not declared in this scope
  780 |             setBlurRegion( QRegion() );
      |             ^~~~~~~~~~~~~
/home/user/RoundedSBE/breezedecoration.cpp:784:13: error: ‘setBlurRegion’ was not declared in this scope
  784 |             setBlurRegion( QRegion( m_windowPath->toFillPolygon().toPolygon()) ) ;
      |             ^~~~~~~~~~~~~
make[2]: *** [CMakeFiles/roundedsbe.dir/build.make:129: CMakeFiles/roundedsbe.dir/breezedecoration.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:457: CMakeFiles/roundedsbe.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
[  3%] Automatic MOC for target roundedsbecommon5
[  3%] Built target roundedsbecommon5_autogen
Consolidate compiler generated dependencies of target roundedsbecommon5
[ 29%] Built target roundedsbecommon5
[ 32%] Automatic MOC for target roundedsbe
[ 32%] Built target roundedsbe_autogen
Consolidate compiler generated dependencies of target roundedsbe
[ 35%] Building CXX object CMakeFiles/roundedsbe.dir/breezedecoration.cpp.o
/home/user/RoundedSBE/breezedecoration.cpp: In member function ‘void Breeze::Decoration::updateBlur()’:
/home/user/RoundedSBE/breezedecoration.cpp:780:13: error: ‘setBlurRegion’ was not declared in this scope
  780 |             setBlurRegion( QRegion() );
      |             ^~~~~~~~~~~~~
/home/user/RoundedSBE/breezedecoration.cpp:784:13: error: ‘setBlurRegion’ was not declared in this scope
  784 |             setBlurRegion( QRegion( m_windowPath->toFillPolygon().toPolygon()) ) ;
      |             ^~~~~~~~~~~~~
make[2]: *** [CMakeFiles/roundedsbe.dir/build.make:129: CMakeFiles/roundedsbe.dir/breezedecoration.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:457: CMakeFiles/roundedsbe.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Rounding in separate effect?

https://github.com/matinlotfali/KDE-Rounded-Corners

The current effect gets shared with the standard breeze decoration. Maybe hand off the rounding functionality to a separate KWin effect that can be toggled as desired? Also, is there any performance difference between your implementation and that of the effect above?

Just Thanks 😃

Just a Big Thanks for this Great and Powerfull KDE Theme 😃
It's the best I tried
I love it

Many Thanks 😄

Libadwaita style

Can you please add a libadwaita style? The gnome style you have is outdated.

Offer a vanilla Breeze variant

SBE has always been kinda slow on my system, even without the rounded corners. Animations drop frames and sometimes are skipped altoghether. Having a version based on stock Breeze decorations would be a lighter alternative for those of us that only want rounded corners but dont have any use case for the features of sbe

displacement of buttons upon maximize

so this happens everytime i maximize a window

seems like the close button ain't being paid enough lol
well, not just the close button, but also any other button being placed on the left side

anyways i hope for a quick patch soon-

Stops working after a while

After approximately a couple of weeks, the round corners disappear. Then I have to reinstall to get it working again. I'm using fedora 38.

Window blurriness every other pixel when using Fractional Scaling on Wayland with rounding shaders

Enabling shaders on Wayland desktops that use fractional scaling (150%) causes visible blurriness every time windows are moved one pixel sidewards (then becomes clear again every other pixel).

Here are some screenshots but it might not be too obvious due to github resizing / browser scaling but much more obvious irl since it seems to affect subpixel rendering.

How it looks without the shaders enabled in Desktop Effects / normally:

How it looks with shaders / every odd pixels sidewards:

The ff. zip contains the lossless png images of the screenshots. Viewing with feh seems to be work well in showing the differences.
rounded-fractional-blur-bug.zip

Here are my versions:
Operating System: Arch Linux
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10
Kernel Version: 6.4.9-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 32 × AMD Ryzen 9 7950X 16-Core Processor
Memory: 58.5 GiB of RAM
Graphics Processor: AMD Radeon Graphics
RoundedSBE-git version: 5.27.4.r233.4f71ab0-1 (from AUR)

Poor man's CSD

https://github.com/jinliu/kwin-deco-chromi

Consider adding the option of having the window decoration cut into where the menubar area usually is. This functionality could be used to make CSD apps look a lot more native on KDE, or just to save space on normal apps by removing the titlebar.

Of course it could be made to look a lot nicer than the implementation I linked.

Corners Shader desktop effect makes kwin crash when playing a game using proton

For a while now my proton games were crashing kwin, and today I finally read journalctl and found a mention of kwin4_effect_cornersshader.so.

So I tried disabling the Corners Shader for RoundedSBE Decoration desktop effect and now everything works. But I can't have rounded corners :(
A fix would be awesome, if it's possible.

I don't know what dumps should I post so for now just what mentions cornersshader.so

Sep 05 14:47:46 OPC-Arch kernel: kwin_wayland[854]: segfault at 80 ip 00007f6b41a9cc8c sp 00007fff18fd9060 error 4 in kwin4_effect_cornersshader.so[7f6b41a9a000+f000] likely on CPU 11 (core 5, socket 0)
Sep 05 14:47:46 OPC-Arch kernel: Code: 41 54 41 89 cc 55 89 d5 53 48 8d 5f 40 48 89 df 48 83 ec 18 4c 8d 6c 24 08 48 89 74 24 08 4c 89 ee e8 48 bc 00 00 48 8b 40 08 <80> b8 80 00 00 00 00 74 18 4c 89 ee 48 89 df 40 84 ed 74 05 45 84

...

Sep 05 14:47:46 OPC-Arch systemd-coredump[18816]: [🡕] Process 854 (kwin_wayland) of user 1000 dumped core.
                                                  
                                                  Stack trace of thread 854:
                                                  #0  0x00007f6b41a9cc8c _ZN4KWin19CornersShaderEffect27windowMaximizedStateChangedEPNS_12EffectWindowEbb (kwin4_effect_cornersshader.so + 0x8c8c)
                                                  #1  0x00007f6b5a2d1637 n/a (libQt5Core.so.5 + 0x2d1637)
                                                  #2  0x00007f6b5c103f79 _ZN4KWin14EffectsHandler27windowMaximizedStateChangedEPNS_12EffectWindowEbb (libkwineffects.so.14 + 0x25f79)
                                                  #3  0x00007f6b5a2d1637 n/a (libQt5Core.so.5 + 0x2d1637)
                                                  #4  0x00007f6b5bd01f6e _ZN4KWin6Window27clientMaximizedStateChangedEPS0_NS_12MaximizeModeE (libkwin.so.5 + 0x301f6e)
                                                  #5  0x00007f6b5bd42272 _ZN4KWin9X11Window8maximizeENS_12MaximizeModeE (libkwin.so.5 + 0x342272)
                                                  #6  0x00007f6b5bc4deb0 n/a (libkwin.so.5 + 0x24deb0)
                                                  #7  0x00007f6b5b266c74 _ZN10NETWinInfo5eventEP19xcb_generic_event_tP6QFlagsIN3NET8PropertyEEPS2_INS3_9Property2EE (libKF5WindowSystem.so.5 + 0x3dc74)
                                                  #8  0x00007f6b5bc14b2a _ZN4KWin9X11Window11windowEventEP19xcb_generic_event_t (libkwin.so.5 + 0x214b2a)
                                                  #9  0x00007f6b5bc176ec _ZN4KWin9Workspace14workspaceEventEP19xcb_generic_event_t (libkwin.so.5 + 0x2176ec)
                                                  #10 0x00007f6b5a298abf _ZN24QAbstractEventDispatcher17filterNativeEventERK10QByteArrayPvPl (libQt5Core.so.5 + 0x298abf)
                                                  #11 0x0000564510afa381 n/a (kwin_wayland + 0x69381)
                                                  #12 0x00007f6b5a2d1637 n/a (libQt5Core.so.5 + 0x2d1637)
                                                  #13 0x00007f6b5a2d2e34 _ZN15QSocketNotifier9activatedE17QSocketDescriptorNS_4TypeENS_14QPrivateSignalE (libQt5Core.so.5 + 0x2d2e34)
                                                  #14 0x00007f6b5a2d2f78 _ZN15QSocketNotifier5eventEP6QEvent (libQt5Core.so.5 + 0x2d2f78)
                                                  #15 0x00007f6b5997893f _ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent (libQt5Widgets.so.5 + 0x17893f)
                                                  #16 0x00007f6b5a29c6f8 _ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent (libQt5Core.so.5 + 0x29c6f8)
                                                  #17 0x00007f6b5a2ea0dc _ZN27QEventDispatcherUNIXPrivate23activateSocketNotifiersEv (libQt5Core.so.5 + 0x2ea0dc)
                                                  #18 0x00007f6b5a2eb2a9 _ZN20QEventDispatcherUNIX13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5 + 0x2eb2a9)
                                                  #19 0x0000564510bc5ba2 n/a (kwin_wayland + 0x134ba2)
                                                  #20 0x00007f6b5a29b404 _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5 + 0x29b404)
                                                  #21 0x00007f6b5a29c8a3 _ZN16QCoreApplication4execEv (libQt5Core.so.5 + 0x29c8a3)
                                                  #22 0x0000564510ae12fb n/a (kwin_wayland + 0x502fb)
                                                  #23 0x00007f6b59027cd0 n/a (libc.so.6 + 0x27cd0)
                                                  #24 0x00007f6b59027d8a __libc_start_main (libc.so.6 + 0x27d8a)
                                                  #25 0x0000564510ae2ed5 n/a (kwin_wayland + 0x51ed5)