4teamwork / ftw.contentpage Goto Github PK

In rolemap.xml (https://github.com/4teamwork/ftw.contentpage/blob/master/ftw/contentpage/profiles/default/rolemap.xml) should be an entry for Event and EventFolder.

getLocation completely ignores the value of the location string-field. Its behavior should be changed in such a way that it first tries to access the location value. If no location value is available it should fall back to its current behavior (get the first addressblock value, if available).

With #47, adding the teaser feature, subscribers are added, setting the inital layout for all ITeaser objects.
When migrating older objects the upgrade step does not set the initial layout.
This leads to inconsistent state.

@maethu Released ftw.contentpage 1.5 but couldn't upload it to plone.org. Unauthorized.

Could you do this for me? Thx

ftw.contentpage should configure its types properly in the reference browser configuration of TinyMCE.

Something like this (tinymce.xml):

<?xml version="1.0"?>
<object>
    <resourcetypes>

        <linkable purge="False">
            <element value="ContentPage"/>
            <element value="EventFolder"/>
            <element value="EventPage"/>
            <element value="News"/>
            <element value="NewsFolder"/>
        </linkable>

        <containsobjects purge="False">
            <element value="ContentPage"/>
            <element value="EventFolder"/>
            <element value="EventPage"/>
            <element value="News"/>
        </containsobjects>

    </resourcetypes>
</object>

• check that all types are configured
• add tests

Add a new field "Department" (German: "Abteilung") to the address block.

https://github.com/4teamwork/ftw.contentpage/blob/master/ftw/contentpage/content/addressblock.py

The description is not moveable so there should not be a button.

We need a setting to hide the whole ListingBlock.

use case: Referencing objects in ListingBlocks from a Text

@jone @phabegger

Goal: The listing should behave like the navigation

Currently it gets the Title of the parent object (ContentPage, News, or EventPage).

It would make more sense to catch die Location if AddressBlock is added inside of an Event.

How add links tinymce another contentpage?
plonebrowser: no items in this folder

https://github.com/4teamwork/ftw.contentpage/blob/master/ftw/contentpage/browser/configure.zcml#L86
If seantis.dir.events is installed, there is no "event_listing" view for the EventFolder...
If plone.app.event is installed, for example, it uses its "event-listing" view.

Original Issue 4teamwork/ftw.contentmenu/issues/3 by @href:

Opening the news_rss_listing in Plone 4.3 will lead to the following error:

Traceback (innermost last): 
Module ZPublisher.Publish, line 60, in publish 
Module ZPublisher.mapply, line 77, in mapply 
Module ZPublisher.Publish, line 46, in call_object 
Module ftw.contentpage.browser.newslisting, line 16, in __call__ 
Module ftw.contentpage.browser.baselisting, line 32, in __call__ 
TypeError: __call__() takes at least 2 arguments (1 given)

The upgrade step is missing (Feature in 1.4 18891ca).

cc @elioschmutz "Implementer"
cc @jone "Reviewer"

😄

@ninfaj Can you take a look a this?

In some circumstances, image boxes does not have the same size, although the surrounding div. has a fixed with/height.

Example: http://wetzikon.4teamwork.ch/testlabor

At the moment if the "Show more news" option is selected and there are no news within the specified dates only the "More news" link is displayed which is kind of odd, since we don't have any news. Maybe we should display a text that indicates that there were no News found within the selected dates.

Whole day events are filtered out in https://github.com/4teamwork/ftw.contentpage/blob/master/ftw/contentpage/browser/eventlisting.py#L42

See e.g. http://www.bern.ch/bern_index

• There are separate listings for subjects starting with letter A, B, ..., Z. German umlauts like ä, ö, ü have to be listed in the categories A, O, and U respectively.
• On each listing page corresponding to a specific letter, all subjects starting with that letter are listed in alphabetical order.
• All links to pages listed for a specific subject are listed in alphabetical order (title).

Results in:

Benutzername
admin (admin)
Anfrage URL
http://localhost:8080/ebikon/@@manage-upgrades
Fehlertyp
ValueError
Fehlerwert
too many values to unpack
Traceback (innermost last):

Module ZPublisher.Publish, line 126, in publish
Module ZPublisher.mapply, line 77, in mapply
Module ZPublisher.Publish, line 46, in call_object
Module ftw.upgrade.browser.manage, line 65, in __call__
Module ftw.upgrade.browser.manage, line 98, in install_with_ajax_stream
Module ftw.upgrade.browser.manage, line 79, in install
Module ftw.upgrade.executioner, line 30, in install
Module ftw.upgrade.executioner, line 40, in _upgrade_profile
Module ftw.upgrade.executioner, line 49, in _do_upgrade
Module Products.GenericSetup.upgrade, line 140, in doStep
Module ftw.upgrade.step, line 27, in __new__
Module ftw.contentpage.upgrades.to1008, line 12, in __call__
Module ftw.contentpage.upgrades.to1008, line 17, in remove_security_settings_from_blocks
ValueError: too many values to unpack

@maethu The merge commit: "2e099c4 Merge pull request #106 from 4teamwork/mle-fix-collaps-js" adds the update.js to the js registry. But the update.js is missing on master.

The update.js file will be added on the following branch: "origin/mle-multiupload" but it's not merged yet...

quick upload is missing

The "splinter" extra of ftw.testing has been removed in ftw.testing 1.12. ftw.testbrowser should be used instead.

Forms folder are not visible in content page listing (authorities?) view. I see two possible ways to show the Form Folders

• Add to the list "Thema"
• Add a new separate Block/List for Form Folder

I would prefere the second option.

If there are a big amount of news, the portlet is confusing.

Solution:

If all the news are in the same year, it's fine. But if it's more than one year, we could implement a collapsable navigation with javascript. It shows all the years with the amount of news. If you click on it, it collapse the months. Another click on a month has the same behavior like now. It opens a view with all news of this month.

• 2011 (234)
• 2012 (534)
  • Jan (10)
  • Feb (234)
    ...
• 2013 (120)

@jone @lukasgraf @phgross @tschanzt What do you think about it? Other solutions?

view.contents() is called twice

The approach of making multiple catalog queries (one per children) may not be a good idea.
Using the sitemap approach may improve performance.
If this doesn't help, some kind of caching has to be implemented.

Example of a slow page with authorities view:
http://www.zg.ch/behoerden

btw. the columns are not equally spread.

see GlobalSectionsViewlet in bern.intranettheme.viewlets.viewlets.py for an idea how to implement this.

@maethu I've just discovered that I've implemented a content categories behavior (in custom code) using collective.z3cform.keywordwidget:

from collective.z3cform.keywordwidget.field import Keywords
from ftw.contentpage import _ as _contentpage
from ftw.contentpage.interfaces import ICategorizable
from plone.directives import form
from zope.interface import alsoProvides


class IContentCategories(form.Schema, ICategorizable):

    content_categories = Keywords(
        title=_contentpage(u'label_categories', default=u'Categories'),
        description=_contentpage(u'help_categories',
                                 default=u'Category for contentlisting'),
        index_name='getContentCategories',
        required=False)


alsoProvides(IContentCategories, form.IFormFieldProvider)

It looks like this:

This does not require defining a vocabulary and has only one field. Might be a better approach than #211.
What do you think?

@ninfaj RSS Feed Link ist nicht sichtbar im head-slot

--> ftw.contenpage.browser.newslisting.pt

French translations needs an update.

Per default, the byline shows us the workflowstate, and some user informations.

With the workflowstate, the user knows, if the content is visible for other users or not. But if the user sets the effectiveDate, the content can be published, but is not visible for visitors. This information is missing in the byline and should be listed...

The byline is overridden in:

• egov.core.viewlets.viewlets.EgovBylineViewlet
  • registered for: egov.core.browser.interfaces.IeGovSpecific
  • inherits from: plone.app.layout.viewlets.content.DocumentBylineViewlet
• ftw.contentpage.viewlets.byline.NewsByline
  • registered for: ftw.contentpage.interfaces.INews
  • inherits from: plone.app.layout.viewlets.content.DocumentBylineViewlet

The implementation in ftw.contenpage is just for News. Both are inheriting from the plone default byline and the news implementation is almost the same as the egov implementation (double code). It just adds the creator to the byline.

1. Whats the reason for the two implementations? Could we merge them? --> The newsbyline could be assume for the egov byline that we can delete the implementation for news.
2. The egov byline will be extended with the new expiration, effective date informations
3. Hint: The default plone byline already includes the expiration date (shows a hint, if the content is expired) but we remove this in our implementation.

Here are the infos to list in the byline:

• the effective date is in the future
  • "not visible"
• no effective date is set or is in the past
  • display nothing
• the expirationDate is in the past
  • plone default ('is expired')
• the effective date is in the past and the expiration date in the future
  • "visible from xxx to xxx"

@maethu @jone @phabegger What you think about?

Currently this is implemented in simplelayout.types.common.
Since there's no dependency on s.t.c, we sometimes (other pkgs may have a dep.) lose those block representations.

Question: Should ftw.contentpage provide default Image/File/Link block representation?

@jone @mbaechtold

If you click on the # - tag, the publishTraverse method is not called... i think because this is not a valid request?? /#

So, the self.letter var will not be updated.

See https://github.com/4teamwork/ftw.contentpage/blob/master/ftw/contentpage/browser/eventlisting.py#L39

If an event starts at the 2014/01/01 and ends at 2014/01/10, the event is no longer visible in the listing after the 2014/01/01

Address should be translated to "Adresse"

There should be the effective date somewhere. Maybe in the byline:

Example: "ftw.contentpage: ListingBlock define columns"

Request from tkiser @ 4tw: The @@HistoryView is not very helpful and could be extended. Example: Plone with activated versioning and ATContentTypes with a diff-function.
See also https://extranet.4teamwork.ch/support/0314-support-www.bgbern.ch-burgergemeinde-bern/0314-tracker-neugestaltung-website-burgergemeinde-bern/38