4paradigm / hybridsql-asserts Goto Github PK

generally, -fPIC is not needed building static library

We'll use GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST in hybridse on mac. But googletest-1.10.0 doesn't have this macro.
The gtest lib in released mac thirdparty, is not 1.10.0. Let's update it to v1.11.0.

actions/runner-images#4060

we'll generally following github runner's milestone and using macos-latest as default macos environment, ref actions/runner-images#9255.

So since release v0.7.0, pre-compiled thirdparty for darwin will use macos-12, specifically requires:

     minos 12.0
     sdk 12.3

We use sed -i '' 's/^#include <syscall.h>/#include <sys\/syscall.h>/' src/logging.cc to make it work on MacOS.
It's better to add a fix patch on https://github.com/4paradigm/common ?

• bison & swig, prefix info is saved at build time, means not portable
• if build zetasql with bazel build //zetasql/parser/..., many required library only built shared, without static library

Fail to build LevelDB.
https://github.com/jingchen2222/hybridsql-asserts/runs/3120408910?check_suite_focus=true

+ '[' -f leveldb_succ ']'
+ tar zxf leveldb-1.20.tar.gz
+ pushd leveldb-1.20
~/work/hybridsql-asserts/hybridsql-asserts/src/leveldb-1.20 ~/work/hybridsql-asserts/hybridsql-asserts/src ~/work/hybridsql-asserts/hybridsql-asserts
++ nproc
+ make -j3 'OPT=-O2 -DNDEBUG -fPIC'
mkdir out-shared
c++  -O3 -fPIC -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT -O2 -DNDEBUG -fPIC -fPIC -c db/db_bench.cc -o out-shared/db/db_bench.o
mkdir out-static
mkdir out-shared/db
error: unable to open output file 'out-shared/db/db_bench.o': 'No such file or directory'
1 error generated.
make: *** [out-shared/db/db_bench.o] Error 1
make: *** Waiting for unfinished jobs....
Error: Process completed with exit code 2.

Retry building might success.
Maybe we can upgrade to higher version leveldb
google/leveldb#556

currently artifact name has datatime instead of version from tag. so it is not so easy to construct dynamically from a version number.

Task:

1. rename artifact name to thirdparty-${version}-${os}-${arch}-${optional_distro}.tar.gz
2. for macos, rm the -i386 suffix, no need

workflow_dispatch accept 2 args:

• repo path
• commit

so it is possible to run test over PRs from OpenMLDB that changes third party