4ch1m / mozext Goto Github PK

I updated the add-on to v2.6.1 in TB 78.7.1 and transferred my signatures from the old to the new.

For some of my identity I have signatures, they always consist of text and html version. The text version starts with

-- 
Blabla

and the html version with

<pre>-- 
Blabla</pre>

and enabled Automatically switch to assigned signature upon changing identity.

Now if I open an email composer window in pure text mode and change my identity, a new empty line is inserted above the signature. That happens on every identity switch.

If I open an email composer window in html mode, changing identities do not insert this additional line.

I double checked, that I don't have any empty line before the -- .

What can I do, that this additional line is not inserted with every identity switch?

Hey @4ch1m,

I just wanted to say thank you for your hard work and that you haven't abandoned your great add-on Signature Switch!

I am looking forward to testing the Beta version!

Cheers

This could well be something you can do nothing about, but I thought you should at least know in case you get support requests.

I’m using the Cinnamon desktop & Manjaro Linux, but I’d guess it’s probably the same in all GTK environments.

After installing the new version, I set up signatures, but could not assign a signature to an identity. The widgets did not respond at all. Before reporting it I decided to try again and after a lot of clicking & double-clicking I did eventually get a response. I can now assign signatures, but it’s not a smooth process.

The widgets seem to only have a small area on the left that responds. The arrows are completely unresponsive. Maybe beyond your control, but worth knowing about.

When accessed using the keyboard (TAB + arrows) they work as expected, but it didn’t occur to me to try that!

The widget only becomes active to the left of where the cursor is.

Please check the FAQ section on my website before creating issues here.

   → mozext.achimonline.de

Thanks!

Thanks for updating signature switch to TB 78!

One of the features I miss from the previous version is the ability to turn on the signature from a right click in the email body.

I know the menu is now on the top right and there is also a keyboard shortcut for it but would personally like the right-click path back.

(Windows NT 10.0; Win64; x64; TB 88)

Steps to reproduce: I entered the email address, then a subject. Then I saved the mail as draft.
If I then want to edit it, the email address line is empty.

Thank you for the nice add-on.
I am using Windows 10 64bit + Thunderbird 78.3.2 + signature switch 2.1.0.

When I write a new email and insert a signature using the signature switch, a new line is inserted into the body of the email as shown in the attachment.

My purpose is to switch the "signature" when I use a different mail account ! Not when I change the recipient. I cannot list all the recipients I send mail to with a specific account!

Hope that can be introduced in a future version.

Thanks.

Ramel

Starting a new issue from comment here.

It's definitely still there. I'm using Thunderbird 78.3.2. I have one signature ("standard") that is simply a fortune cookie, and I do all my email in plain text.

1. Start a new message
2. Signature Switch toolbar button -> see "Switch on", "Standard" and "options".
3. click "Switch on" -> see signature
4. Toolbar button now shows "Switch off" (and the other two)
   5 click "Switch off" -> newlines in mail become two with signature still there and "Switch off" still in menu
5. click "Switch off" again -> same result
6. at some point (possibly after deleting body of email) menu changes to "Switch on"

Try again, and the same effect, except it never goes to "Switch off", always staying with "Switch on", and unlike with "Switch off", a new signature line is added. (Again, after deleting the body of the message and clicking "Switch on" again, it changed to "Switch off".)

Clicking "Standard" (my signature name) at any point, and an additional signature shows up below the others.

Very strange if nobody else is seeing it.

(BTW, is the "default" signature supposed to be added to new messages by default? Cause it's not.)

Thanks!

Hello,

in the previous version, we could change signature after the email is written (there was a "Signature Switch" line in the option tab).

I have the case of 2 people using the same email address and only switching their signature to distinguish between them.

Is it still possible ?

Thnaks.

Thomas.

• That is a third confirmation window.
• It is not obvious how one uses the confirmation window. For, am I to type a dash at any point?
• The solicited arrow keys get passed to the window underneath as well as to the confirmation window itself: pressing those keys moves one around in another window.

You would do much better to copy the Linux utility apt, which, in the case of some operations, requires the following for confirmation: first, typing y/yes; second, typing (something like) do as I say. So: two confirmations, not three; and no - somewhat malfunctioning - arrow keys and dashes.

Thank you for your addOn.

In a new email window, i have written an email and at the end, before sending it i changed the signature using the "signature switch" button. As soon as i clicked on the new signature from the menu, all text i had written disappeared.

This had happened in the past with an older version and i was able to Undo and restore my text. With the current version though, even this does not work. As soon as a new signature is selected, the existing text is lost.

I wrote a long e-mail, in two languages.

Both language were separated by (not sure about the number of dashes):

--------- English Version ----------

Below that, I had a bloc with a custom signature for the occasion.

I was about to send it, then on second thought, I added a new recipient. Due to automatic signature switching, half of my message was discarded, plus the custom signature (not a big deal for the signature). No obvious way to undo the operation.

• Thunderbird 91.4.0 (64 bits) -- Arch Linux. Composer in text mode.
• Signature switch 2.8.0

I lost an hour. I will disable the extension for now. Thankfully I still have half of it.

In the older versions of Signature Switch, it used to be so that I could setup a file for each signature. That is, updating the file automatically updated the signature used in Thunderbird. (This is highly practical since I could then synchronize my signatures using Nextcloud/Dropbox/whatever in a portable way.)

Unfortunately, this feature is missing from the newer versions (and the older ones are not compatible with Thunderbird 78.4+). The only way I see to add new signatures is to paste them into the config panel. Was there a reason for it to be dropped?

I have inserted an image to my sig (HTML sig).

<img src="{{MyLogo}}" border="0" width="100" height="60">

When i reply to an email, the signature is displayed above the quoted message (which is great) but instead of the image, an empty square is displayed. If i click on the "signature switch" button and re-select my sig, the image is displayed but the sig is now moved under the quote. When a new email is composed, the image is almost always displayed properly.

The desired behavior would be for the image to be displayed initially (when the sig is placed above the quote).

Latest TB, latest SigSwitch, under Win10 fully updated.

I had SignatureSwitch configured for my use case and it was working well in TB 68. I used a "Pre-Load Executable".

Somewhere on the path to TB 78, this functionality got lost. Unfortunately I did not notice it immediately, because I have set the signature in the account settings to a very similar one.

The "Config editor …" shows the following Preference Names:
extensions.signatureswitch.

• autoswitchpriorities: ANM
• composerpath: /usr/bin/xed
• contextmenu: false
• defaultsignature: 0
• encoding: UTF-8
• initdelay: 1000
• offbydefault: false
• preloadexecutable: true
• preloadexecutablepath: /home/<user>/bin/signature_switch
• preloadexecutablewait: true
• shortcut_cycle_key: C
• shortcut_cycle_modifier_accel: false
• shortcut_cycle_modifier_alt: false
• shortcut_cycle_modifier_control: true
• shortcut_cycle_modifier_meta: false
• shortcut_cycle_modifier_shift: true
• shortcut_onoff_key: Y
• shortcut_onoff_modifier_accel: false
• shortcut_onoff_modifier_alt: false
• shortcut_onoff_modifier_control: true
• shortcut_onoff_modifier_meta: false
• shortcut_onoff_modifier_shift: true
• signatures: Standard signature (gets overwritten by the pre-load executable)*%ProfD%/signature.txt* -----*-*-*-

but all settings in SignatureSwitch configuration screen are empty.

How can I get the old settings into the new SignatureSwitch?

Could the icon be more dark? With a light theme is invisible.

Thanks!
mario

Below code only gives me a black border. Border, width and height work as expected.

<img src="{{Logo}}" border="3" bordercolorlight="#006fdd" bordercolordark="#b9dcff" width="70" height="80">

New at HTML, and trying to explore things. Any helpful documentation?

(re)integrate PR #49 from @ValdikSS

TB 48.4
Signature Switch up to 2.3.0

Hello Achim,
I have been using signature switch over the years and updated TB step by step. Now after installing new Signature Switch add-on I did not get it to work nor to see any menu items for several weeks...
Checking prefs.js showed many relics form older versions. After editing prefs.js, deleting all signature switch entries and reinstall of the extension everything is working fine!
So this must somehow be considered in the installation process.
Thank you very much for your efforts in creating important extensions
Karlheinz

Hi,

would be great to have an option that the signature will be added in top of an answered mail.

If we answer a big mail, the signature is far at the end. So it's better in top.

Great thanks for this best addon.

I've done some tests with 2 signatures and I can't find a consistent behaviour in how rules are applied.

I think with the previous version the rule was looking at the first address and wouldn't change after that.
In this version, it also changes based on what comes after that, but I can't find the pattern.
I've tried with something like this:
Sig1 is higher than Sig2
* triggers Sig1, *@domain.com triggers Sig2

Case 1
U1 U2 U2
-> Sig1
Remove U1
-> Stays as Sig1, which is wrong

Case 2
U2 U1
-> Sig1, even though it's not the 1st one
Add U2
-> No change

Case 3
U2
-> Sig1, which seems to indicate that something is broken.

Case 4
I've changed the order of priority
U2 U1
-> Sig1
Add U2
-> No change, probably because now Sig1 has the highest priority.

I'm guessing priorities play a role, but when I set them right, it doesn't work as expected.
Maybe because I'm using a simple * wildcard for "all emails" as the top priority signature.
I'm trying to set a simple rule where I have one signature for internal messages and another for anything external.

Hi,

I use auto-switch to distinguish between company internal and external recipients. But when I send an email to an external recipient and have at least one of my colleagues in the To: field, it switches the signature. A option to say match-one or match-all would be nice. Does this make sense for you?

Best

P.S.: Great extension!

Hi, thanks for bringing this extension to TB 78 in a short time, great work!

On Thunderbird, I have the plain-text editor set as default, and have no default signature set. When answering messages, if I add a signature using Signature Switch, the quoted text in the message is converted to regular plain text (including the '> ' characters of the quotation), which means that the mail will be sent by Thundebird with spaces in front of the '> ' to make sure they wont be considered quotes by the recipient MUA.

As an example, here is a mail before adding a signature. The quoted text is clearly visible in blue, while the answer is in white:

Now, if I add a signature, the quoted text becomes regular text, and sometimes even jumps on the next line because of line wrapping, making the thins even messier:

I'm not sure whether this is a bug/limitation of the MailExtension API of Thunderbird, or a bug in SignatureSwitch, but it is unfortunately very annoying... do you think it is possible to correct this or does Thunderbird needs a patch?

For our company, an important feature of the old version of SignatureSwitch was that it could load signatures automatically from a file. The signature files were regularly, centrally updated and the employees didn't had to update their signatures themselfes.

Is it planned to add this feature again in this new version?

Running Windows 10 Thunderbird 78.3.3. Had to reinstall SW in order to get the menu to appear. It does not recognise any previous signature files, even though they are still in the C:\Users*\AppData\Roaming\Thunderbird\Profiles*.default\Signatures directory. So, I chose SW button>Signatures>New Signature I can change the name, but I can't edit the default text (plain or html). The "Moe Zilla" text is not selectable. The cursor sits in the upper left corner of the edit window. Suggestions? Thanks.

--------- UPDATE ---------
I changed the name of the signature and saved it. Opened a new message, Inserted the signature, which was empty. From the message window I selected SW button>Options and then I was able to edit the signature. In other words, it fixed itself. But there is a bug in there somewhere. Hope that helps.

To reproduce the issue (Im using latest Thunderbird version on Windows):

1. Create a brand new email
2. Start typing some text in the mail body (before the signature)
3. Change the email recipients list
4. The email body is removed

This is very annoying as you have to rewrite the entire email body.
Are you providing (will you provide) a setting to change this behavior ?

I have noticed that in menu Tools, somehow a submenu "Addon options" appear when there are configurable addons. It would be better if Signature Switch could add an entry there instead of having the button in the main window (having it in the "Write" window is just fine though). Signature Switch's options are something that will be rarely used, so having a button in the main window is overkill IMO.

Hi,

I've been using Signature Switch for some time and today, I a long line of dashes appeared to be added just before my signature, except when signature was off.

It took me quite some time to understand what it was : it's the visual separator. Why did it appear now ? No idea... The option as not selected in the configuration. Had to check the box then uncheck it and the visual separator was no more added.

Not a big problem, but it should not appear some day for no reason and when you don't check it (and you don't know it even exists), you may take quite some time to understand what it is.

ANyway thanks for this extension, even if I've lost all my signatures trying to understand what was happening (removed the extension, re-added it, but Thunderbird lost it while running with all my data).

Is there a setting where I can use a domain list the other way round? As this should be a very common scenario, I am quite sure that it is possible, but I did not find the setting (I use this plugin and it's predecessor since many years). The scenario is: insert a signature always but NOT when the domain is a specific domain like the company domain (i.e. do not insert a signature for internal emails).

On email reply, "--" is not added before the signature. I have a feeling it's intentional but perhaps there should be an option for it instead.

Hi
Thanks for your great extension. I juste created two signature : html and text.

Is there a way to configure an auto switch between them if I use text and html email composing ?

Thanks !

Hi. Thank you, thank you for Signature Switch. It has been my most valued add-on to Thunderbird since close to (if not) when you released it 15 years ago.

Unfortunately, it's not working with the new Thunderbird (78.1.0). Is there a chance that it can be made to work, or will it be going the way of the dodo like so many of the great FireFox add-ons that were doomed with the change to "Quantum"? (almost 3 years, and I still miss them 😢 )

Hello,

the signature switch is working great. However, I want to remove the two dashes that appears above my html signature. I did the adjustment in the configuration editor (https://support.mozilla.org/en-US/questions/1019583), but the dashes still appears. I have another Thunderbird installation without Signature Switch, and in there I can remove the two dashes using config editor in Thunderbird.

Apart from an initial Paste action to the HTML text (which worked fine), additional Copy or Paste actions in there do not work. I have tried Copying using either CTRL+C or context-menu Copy, but pasting to notepad pasted nothing.

Pasting to a new TB email however pasted this (1st image):

https://imgur.com/a/XABBwDa

Doubleclicking on it, displays the dialog that appears in the 2nd image.

Thunderbird 91.0
Signature Switch 2.8.0
I think this issue came up with the last update to 2.8.0 (it did not happen before 02.09.2021):

• Normal text signatures (not html)
• Signatures include a lot of underscores to create a horizontal line
• When signature is inserted the horizontal line is reduced to 2 underscores

"______________________________________________________________________"
->
"__"

I first thought that there could be a kind of auto option to replace such a kind of text, but I couldn't find anything.
Perhaps something was introduced in 2.8.0 ?

In the signature edit window, i personally use HTML signatures only. It would be nice if there was an option (boolean) in order to show the HTML part automatically when you edit a signature, instead of the "text" which is now the default.

Clicking on send does not do anything on Thunderbird 91.0.2 and 91.0.3 64bit.
Closing and saving a draft does not close and save either (no reaction).

Solution: Disable add-on temporarily

Thanks for your work!

When I select a signature in the compose window it no longer inserts the signature in the message.

Thank you so much for rewriting Signature Switch for the new Thunderbird!

I see that you mention the ability to use fortune cookie files (like with the legacy SS), but I can't figure out how to do that. Is that feature still being developed/rewritten, or am I just missing the obvious?

Thanks.

Hi,

First of all, thanks a lot for all your efforts in keeping signatureswitch alive, also for TB78! This addon really makes my live easier.

Thanks also for your recent new auto-switch feature! This made me think about another cool addition: I am using TB for private and for business purposes. emails from my business identity(s) should never ever contain one of my private signatures and the other way round because this can be very embarrassing. Would it be possible to have two different sets of signatures which one then can assign individually to the respective email identities. Again, I have been living without this for years but your new feature triggered this wish. I would not even dare to ask for a second level of auto-switching in which the addon would learn which signature to use for which recipient.

Again, thanks for all your continuous effort
PUKK

Hi,

first of all: thanks a lot for this awesome extension.
Unfortunately, it is currently not working for me (presumably after an update). I am currently running TB 78.3.2 (as packaged in Ubuntu 20.10) with SignatureSwitch 2.4.0. I can manage signatures, but trying to insert it into a mail results in the following error in the javascript console:

Uncaught (in promise) TypeError: browser.tabs.sendMessage is not a function
    removeSignatureFromComposer moz-extension://ba4d6a3b-3cb5-4d3c-afaa-bf41abe493ca/background/background.js:436
    appendSignatureToComposer moz-extension://ba4d6a3b-3cb5-4d3c-afaa-bf41abe493ca/background/background.js:388
background.js:436:18

I'm not sure if this is related, but the TB 78.4.0 release notes (dated Oct. 21, 2020) list MailExtensions: browser.tabs.sendMessage API added. If this is indeed the root of the problem, would it be possible to somehow implement backwards-compatibility with TB versions before 78.4.0?

When I forward a message, a signature is always appended. This does not happen if Signature Switch ist disabled.

I'm using Signature Switch 1.8.2 in Thunderbird 68.11.0 on Windows 10. I have disabled both options to append signatures in Composition & Adressing section for all my email accounts,

Default Action

When opening a new compose window ...

When choosing a value there (i.e. "Insert the default signature"), it seems that even though it is stored, when closing and reopening the Options window, "Do nothing" is always selected.

Hi,

first of all a big thanks for migrating to TB 78 support 👍

I have a problem with the auto switch on a reply. I want to disable the footer on company internal mails, so I created a blank signatuere with Auto switch '*@company.de'. It works on new messages fine.

On a reply the signature is only removed, when the address is removed and added again.
On a forward the address has to be removed and added again, but then the senders signature and not mine is removed.

I have multiple accounts, so that the signatures are set in the accounts - is that a problem?
If so, would it be a feature request to have the account(s) or the sender address in the signatures configuration?

Thanks
Freddy

:\Users\Virgil Stokes\mozext\signatureswitch-me>npm install

signatureswitch@ postinstall C:\Users\Virgil Stokes\mozext\signatureswitch-me
./copy_node_modules.sh

'.' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! signatureswitch@ postinstall: ./copy_node_modules.sh
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the signatureswitch@ postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Virgil Stokes\AppData\Roaming\npm-cache_logs\2020-11-08T18_30_36_223Z-debug.log
2020-11-08T18_30_36_223Z-debug.log

When adding a signature that has an auto switch filter for domain endings, for example: "@.com" the dot has to be escaped like in "@.com". Not escaping the dot will let every email address containg "com" trigger the switch - not only those containing ".com".

This should be documented or automatically escaped.

The new signature switch allows one to specify arbitrary text in the signature but as far as I understood it, it should be standard practice to use -- as a signature separator. It would be nice for signature switch to allow including the separator by default rather than asking the user to include it in their own signature.

On a related note, for html signatures, I curently resort to --<br> but am not sure this is best practice.

Hi,

as soon as I enable "Signature Switch" (version 2.3.1) extension, my mails get an additional empty line added on top of the mail body. This is what I write:

and this is what I receive:

(w/o the red frame of course :-). Mails are text-only, Thunderbird versions are 78.4.3 running on mac OS and 78.4.0 running on CentOS 7.9.

As soon as "Signature Switch" is disabled, there is no more additional line. This behaviour is reproducible with both Thunderbird instances and does not depend on a signature being added or not.

Let me know if you need additional information or testing.