Giter Club home page Giter Club logo

seeker's Introduction

Hi there 👋,

Nice meeting you, I am Vivek Singh!

  • Android Developer
  • Mostly working on Android 📱 , Kotlin 💥 and Backend.
  • Open source ⭕ contributor.
  • Tech writer on medium.com

Connect with me:

@2307vivek | Twitter @2307vivek | Medium Vivek Singh | Email



Profile Views



My GitHub stats

seeker's People

Contributors

2307vivek avatar eraycantazeguney avatar maxr1998 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

seeker's Issues

Support passing a separate value for the thumb

It'd be useful to be able to pass the value for the thumb separately, so that it can have its own progress while seeking.
See this screenshot from the YouTube app for an example use case:
Screenshot

If necessary, I can look into implementing this myself.

`onValueChangeFinished` dispatched before `onValueChange` when tapping the seeker

As the title says, I noticed that the onValueChangeFinished callback is invoked before onValueChange when only tapping the seeker instead of pressing and dragging on it. This seems to be a race condition caused by dispatching the dragState change from a CoroutineScope, whereas the onValueChangeFinished callback is invoked immediately from onTap.

It appears to be easily fixable by moving the onValueChangeFinished inside the launch block as well. I'll open a PR with this fix later.

Lower minSdk to 21

I'm planning to use this in one of my apps but couldn't since we still support Android 5 (minSdk 21). I wondered whether it would be technically feasible to lower the minSdk to that version. Thanks!

Make Seeker min height from Dimensions

Hello, when I set thumb radius to 0.dp there is still un-needed padding i suggest making

BoxWithConstraints( modifier = modifier .requiredSizeIn( minHeight = max( dimensions.thumbRadius* 2, trackHeight), minWidth = SeekerDefaults.ThumbRippleRadius * 2 ) .progressSemantics(value, range, onValueChange, onValueChangeFinished, enabled) .focusable(enabled, interactionSource) )

to give the flexibility of removing the min height constraint.

Thanks

Progress indicator doesn't appear as expected if transparent colors are used for track.

Description

The progress indicator doesn't appear as expected if the track/segment color has an alpha property. This is more likely happening because progress indicator overlapes the track/segment using a BlendMode.SrcIn which uses the destination opacity in the output layer.

This happens only when the colors used for Seeker track and progress has some transparency.
Android Large - 1

In the above image the MaterialTheme.colors.primary.copy(alpha = 0.24f) is used for the track.

Expected

Android Large - 2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.