22degrees / roundcorners Goto Github PK

affects all units/devices when the elements below becomes hidden

Probably a mistake in the template.
With Nvidia, AMD graphics card and different drivers.

Observe and check if others have the same problem.

affected units: Samplers, Effects, Microphones/Aux

steps to reproduce the failure:

1. expand the sampler with all UI elements (maximum height)
2. reload the skin
3. hide the additional UI elements and shrink the sampler (minimum height)

Result: SizeAwareStack doesn't shrink when the inner element is shrinking.

steps to demonstrate the proper functionality:

1. hide the additional UI elements and shrink the sampler (minimum height)
2. reload the skin
3. expand the sampler with all UI elements (maximum height)
4. hide the additional UI elements and shrink the sampler (minimum height)

Result: SizeAwareStack expand and shrink when the inner element is resizing.

Hello !

I was trying out your RoundCorners skin with the latest release 2.2.3 on ubuntu 20.20

i copied the files into /usr/share/mixxx/skins/RoundCorners and loaded it in the gui , it flicked and then segfaulted.

heres some of the error messages , i've trimmed the repeating Argument missing errors with various number combos as they all followed pattens.

Warning [Main]: src/skin/legacyskinparser.cpp:2110 SKIN ERROR at skin:tool_bar.xml:344 <Connection>: LegacySkinParser::setupConnections(): EmitOnPressAndRelease must not set false
Warning [Main]: src/skin/legacyskinparser.cpp:2110 SKIN ERROR at skin:skin_settings.xml:40 <Connection>: LegacySkinParser::setupConnections(): EmitOnPressAndRelease must not set false

Warning [Main]: QString::arg: Argument missing: "2" , 28
Warning [Main]: QString::arg: Argument missing: " 3" , 29
Warning [Main]: QString::arg: Argument missing: "3" , 30
Warning [Main]: QString::arg: Argument missing: " 4" , 31
Warning [Main]: QString::arg: Argument missing: "4" , 32
Warning [Main]: QString::arg: Argument missing: " 5" , 33
Warning [Main]: QString::arg: Argument missing: "5" , 34
Warning [Main]: QString::arg: Argument missing: " 6" , 35
Warning [Main]: QString::arg: Argument missing: "6" , 36
Warning [Main]: WARNING: slotNumber out of range
Warning [Main]: EffectPushButton "[QuickEffectRack1_[Channel1]_Effect1]" , "enabled" is not an effect button parameter.
Warning [Main]: WARNING: slotNumber out of range
Warning [Main]: EffectPushButton "[QuickEffectRack1_[Channel2]_Effect1]" , "enabled" is not an effect button parameter.
Warning [Main]: ControlDoublePrivate::getControl returning NULL for ( "" , "visual_key_distance" )
Warning [Main]: QString::arg: Argument missing: " 1 " , 1
Warning [Main]: QString::arg: Argument missing: " 2 " , 2
Warning [Main]: QString::arg: Argument missing: " 3 " , 3

Warning [Main]: QString::arg: Argument missing: " 6" , 35
Warning [Main]: QString::arg: Argument missing: "6" , 36
Warning [Main]: ControlDoublePrivate::getControl returning NULL for ( "" , "visual_key_distance" )
Warning [Main]: QString::arg: Argument missing: " 1 " , 1
Warning [Main]: QString::arg: Argument missing: " 2 " , 2

Warning [Main]: QString::arg: Argument missing: " 5" , 33
Warning [Main]: QString::arg: Argument missing: "5" , 34
Warning [Main]: QString::arg: Argument missing: " 6" , 35
Warning [Main]: QString::arg: Argument missing: "6" , 36
Warning [Main]: WARNING: slotNumber out of range
Warning [Main]: EffectPushButton "[QuickEffectRack1_[Channel3]_Effect1]" , "enabled" is not an effect button parameter.
Warning [Main]: WARNING: slotNumber out of range
Warning [Main]: EffectPushButton "[QuickEffectRack1_[Channel4]_Effect1]" , "enabled" is not an effect button parameter.
Warning [Main]: ControlDoublePrivate::getControl returning NULL for ( "" , "visual_key_distance" )
Warning [Main]: QString::arg: Argument missing: " 1 " , 1
Warning [Main]: QString::arg: Argument missing: " 2 " , 2
Warning [Main]: QString::arg: Argument missing: " 3 " , 3

Does it just not work with the release version yet ? happy to help test fixes or workarounds

Some ideas

• single deck per screen (possible since 7152d39)
• bigger waveforms
• more options for beatgrid and bpm adjustments
• every deck can switch to edittrackmode and vice versa

preview:

The menu bar could shrinking for smaller screen sizes.
Styles:

• icons with text
• text only
• icons only

concerns the sampler and preview player

Default:

• 2 decks (full)
• 1 mixer (full)
• sampler
• main device
• internal clock

Testing RoundCorners master branch with Mixxx 2.4 Beta, I get this:

waiting for PR mixxxdj/mixxx#1501

The changeable color is part of #1117

Great skin. Love it. I'm currently using the LateNight skin and the load to deck 1 and load to deck 2 buttons on my numark mixtrack pro midi controller work ok. These have no effect in the roundcorners skin. Which files would I need to change to get this working. I want to work on this as I gotta have this skin.

It could be placed in the main device.

Skin is great! I ask if possible insert in the skin crossfader slide control.
Thanks

On every mixxx start the skin shows the settings overlay.
It is a missing feature in WWidgetStack, I think.

Workaround: click twice on the SETTINGS in the top menu bar

This skin looks nice. It would be great to include it in Mixxx. I do not think we have time to do a thorough review of a whole new skin for Mixxx 2.1, but it would be good to get it merged upstream for Mixxx 2.2. To submit it for inclusion, fork the mixxxdj/mixxx repository, clone your forked repository to your computer, add this skin as a new folder in the res/skins folder, commit it on a new branch, and push. Then make a pull request for the mixxxdj/mixxx repository. It's fine if the skin is not complete yet, just make sure to say so in the pull request. Having a work-in-progress pull request upstream will let more people test the skin and give feedback.

fixed with 011d4aa