2072 / decursive Goto Github PK

View Code? Open in Web Editor NEW

7.0 5.0 5.0 2.54 MB

Decursive: https://www.wowace.com/projects/decursive

License: GNU General Public License v3.0

Lua 100.00%

decursive's Introduction

Decursive for World of Warcraft

Download and documentation:

http://www.2072productions.com/to/decursive.php

http://www.wowace.com/addons/decursive/

Documentation is also available under the doc/ directory:

./doc/Description.txt

./doc/user-actions.txt

./doc/commands.txt

./doc/macro.txt

./doc/MUFs.txt

./doc/faq.txt

decursive's People

Contributors

Stargazers

Watchers

Forkers

astra-fox lonewanderer-gh armstrjare teelolws meivyn

decursive's Issues

How does decursive know the roles of players in the raid?

I'd like to use the role-based prioritization but it's unclear to me how decursive determines each raider's role. Especially tanks.

I have been troubleshooting another issue when I noticed that Decursive about every 20-30 seconds grows to about 200+ MB of memory usage before Garbage Collection kicks in and it drops back down off the list. And than I watch it grow back up to 200+ MB again over and over. Obviously GC takes care of the leaked memory, but it's not free, and might be something worth looking at. I've honestly never noticed it before, but I also don't watch my addon memory usage that often either. So not sure how long it's been doing this.

Minor typo in settings panel

The setting in the image shows "Debuff preiodic full scan", but it should be "Debuff periodic full scan"

LUA Error Fatally Breaking Decursive

49x Decursive/Dcr_DebuffsFrame.lua:1487: attempt to call upvalue 'GetItemCooldown' (a nil value)
[string "@Decursive/Dcr_DebuffsFrame.lua"]:1487: in function `SetColor'
[string "@Decursive/Dcr_DebuffsFrame.lua"]:1186: in function <Decursive/Dcr_DebuffsFrame.lua:1144>
[string "@Decursive/Dcr_utils.lua"]:878: in function `func'
[string "@Decursive/Libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:57: in function <Decursive/Libs/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
InCombatSkipped

Possible to disable blacklist?

Is this even possible with your current code?

Decursive/Dcr_Events.lua

Lines 779 to 792 in 5f9a738

 if (auraTYPE_failTYPE == SPELL_FAILED_LINE_OF_SIGHT or auraTYPE_failTYPE == SPELL_FAILED_BAD_TARGETS) then 

 if not self.profile.DoNot_Blacklist_Prio_List or not self:IsInPriorList(self.Status.Unit_Array_UnitToGUID[self.Status.ClickedMF.CurrUnit]) then 

 self.Status.Blacklisted_Array[self.Status.ClickedMF.CurrUnit] = self.profile.CureBlacklist; 

 self:Debug("|cFFFF0000XXXXX|r |cFF11FF11Updating color of blacklist frame|r"); 

 self:ScheduleDelayedCall("Dcr_Update"..self.Status.ClickedMF.CurrUnit, self.Status.ClickedMF.UpdateSkippingSetBuf, self.profile.DebuffsFrameRefreshRate, self.Status.ClickedMF); 

 end 

 self:SafePlaySoundFile(DC.FailedSound); 

 --[=[ 

  elseif auraTYPE_failTYPE == SPELL_FAILED_BAD_IMPLICIT_TARGETS then 

  self:AddDebugText("ERR_GENERIC_NO_TARGET", "Unit:", self.Status.ClickedMF.CurrUnit, "UE:", UnitExists(self.Status.ClickedMF.CurrUnit), "UiF:", UnitIsFriend("player",self.Status.ClickedMF.CurrUnit), "CBEs:", timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellID, spellNAME, _spellSCHOOL, auraTYPE_failTYPE); --]=] 

 end

I don't get the point of that feature, and as a healer, I find it actually very annoying, I had to look into your code and disable that manually (but I'd rather have it fixed in the addon than do it every single update). I'd like to know if it could be possibly implemented in a future release.

My point is that I don't want Decursive to auto-blacklist people who are out of the line of sight, because I'd rather move and find them than let them "notice they have to move near me" and die from the debuff. I don't get the point of that feature honestly. Would appreciate it if you could explain a bit.

I would not mind making PR to make it at the very least configurable, but testing this stuff is actually not very straightforward.

Personal life issue

I currently have a severe condition that will prevent me from working on this project for the time being.

[Retail] Curses not tracked with Shaman Improved Purify Spirit

I'm not sure if I'm doing something wrong, but when I take Improved Purify Spirit on my Shaman in retail, the option to track curses is not available. I see 8bf1557 was meant to address this, but it looks like there still might be issues. I'm running the latest v2.7.9.2 release.

I've been a long time user of decursive, so just also wanted to say a big thank you for the time and work you've put in for this! 🙏

Affliction Priority Doesn't Stick If Item Removed

The use case is Major Recombobulator in WotLK Classic. I want to cure Polymorph as the highest priority. When I assign it the highest priority, and then unequip the item, it removes it from the priority list. That's fine, but when I re-equip the item, it should remember the priority that I assigned to it. Currently it will just assume the lowest priority.

Remove BugGrabber Dependency

link to curseforge issue: https://www.curseforge.com/wow/addons/decursive/issues/167

Bug Grabber Indexing a NIL

There was an update to WoW at my end-of-gaming on 19-Sep-2023. When I logged in today (20-Sep-2023), I'm seeing this error.

BugGrabber.lua:319: attempt to index local 'stack' (a nil value)

Support for Wrath of the Lich King

Hello! Now that pre-patch is live, I am going through my addons and updating them for wrath (3.4.0) and I notice that there's not yet any communication (here or on wowace) about whether you are planning to update Decursive for wrath? Please, could you let us know if that's something you are planning on supporting? Thanks!

[Request] Add #showtooltip to the Decursive macro

Not sure if you'd agree with this, but I think it would be nice to have #showtooltip Remove Lesser Curse (or Remove Curse for retail) in the macro text the addon creates. Personally I just find it a lot easier to manage my macros by their macro icon, and doing this would give it the spell icon of the remove curse ability appropriately. Plus the question marks are ugly. 😀

Let me know your thoughts.

SoD Mages can't dispel magic effect with Advanced Warding rune.

In Season of Discovery, the helm rune Advanced Warding changes Mages spell Remove Lesser Curse to Remove Greater Curse, which also removes 1 harmful magic effect from an ally.

The decursive frame in groups/raids does not allow us to remove Magic effects.

GetBackdrop error

### this error is coming up since patch 9.1.5 of warcraft went live.

Message: ...ce\AddOns\Decursive\Libs\LibQTip-1.0\LibQTip-1.0-48.lua:543: attempt to call method 'GetBackdrop' (a nil value)
Time: Wed Nov 3 09:21:02 2021
Count: 6
Stack: ...ce\AddOns\Decursive\Libs\LibQTip-1.0\LibQTip-1.0-48.lua:543: attempt to call method 'GetBackdrop' (a nil value)

Locals:

### and this is the 2nd error message.

Message: ...ce\AddOns\Decursive\Libs\LibQTip-1.0\LibQTip-1.0-48.lua:543: attempt to call method 'GetBackdrop' (a nil value)
Time: Wed Nov 3 09:28:37 2021
Count: 1
Stack: ...ce\AddOns\Decursive\Libs\LibQTip-1.0\LibQTip-1.0-48.lua:543: attempt to call method 'GetBackdrop' (a nil value)
[string "@interface\AddOns\Decursive\Dcr_DebuffsFrame.lua"]:886: in function `OnEnter'
[string ":OnEnter"]:1: in function <[string ":OnEnter"]:1>

Locals: self =

{
UpdateMUFUnit = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:700
OnEnter = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:748
MaxUnit = 80
MFUsableNumber = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:233
SavePos = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:645
OnPostClick = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:1018
UnitsDebuffedInRange = 0
Create = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:207
Show = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:162
Delayed_MFsDisplay_Update = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:320
RegisterMUFcolors = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:172
OnCornerEnter = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:902
metatable =

{
}
Place = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:511
GetMUFAnchor = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:278
Frame = DcrMUFsContainer {
}
GetFarthestVerticalMUF = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:177
OnAttributeChanged = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:1839
OnPreClick = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:935
new = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:96
Delayed_Force_FullUpdate = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:437
SetScale = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:689
Number = 1
OnLoad = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:929
DraggingHandle = false
GetHelperAnchor = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:299
ResetAllPositions = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:238
ToString = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:202
ExistingPerUNIT =

{
}
OnCornerLeave = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:899
OnLeave = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:891
prototype =

{
}
MFsDisplay_Update = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:327
UnitToMUF =

{
}
Force_FullUpdate = defined @interface\AddOns\Decursive\Dcr_DebuffsFrame.lua:443
UnitShown = 1
}
frame = {
0 =
Object =

{
}
}
MF =

{
LastAttribUpdate = 944654.670000
Debuff1Prio = false
UpdateCountDown = 1
OuterTexture3 = {
}
UnitClass = "MAGE"
UpdateCD = 0
PrevDebuff1Prio = false
usedAttributes =

{
}
CurrUnit = "player"
NormalAlpha = 0.350000
Frame = {
}
FirstDebuffType = false
FrameNum = 1
Debuffs =

{
}
Color =

{
}
CenterText = false
CenterFontString = {
}
CooldownFrame = {
}
OuterTexture2 = {
}
ID = 1
UnitStatus = 8
BorderAlpha = 0.200000
RaidIconTexture = {
}
PrevRaidTargetIndex = false
OuterTexture1 = {
}
Texture = {
}
InnerTexture = {
}
OuterTexture4 = {
}
Parent = DcrMUFsContainer {
}
RaidTargetIcon = false
IsCharmed = false
UnitGUID = "Player-3726-09D928D5"
ToPlace = 1
UnitName = false
PrevCenterText = false
Shown = true
}
Status = nil
Unit = "player"
TooltipText = ""
GUIDw

Cataclysm version?

WoW Classic just got updated from WOTLK to CATA (4.4.0.54481).

Are there any plans to update the addon on Curseforge to Cataclysm?

Disc Priest WOTLK Classic

Hello,

As a disc priest in wotlk classic, decursive is not detecting that I am able to dispel magic. I can dispel disease fine, however, magic effects do not show. In the settings, the option to check magic is grayed out. Any insight?

LUA error happening often

Could copy/pasta text but i have this. it also occurs so often that blizz warning pops up to disable addon.

Love your addon and have used for many years! thanks!

[Feature] Click-through MUF when inactive

Hi, Classic player here.
Would it be possible to add the option to click through the Micro-Unit Frames when there is nothing to dispel? That would allow the MUF to be placed over other interactive unit frames such as Grid and further reduce some mouse movements.
If that was already a thing, I'm sorry but I couldn't make it work.

Several healers dispel is not working with 10.2.6

Version: Retail, 10.2.6
Decursive version: 2.7.16 (latest)

Every healer but pally and monk has had decursive broken for them, it's probably the change they made to combine the spells when you take the improved version in the talent tree from what i can see.

Macros that use the non-healer versions of dispels will now override the ability with the healer dispel variant if the player is in a healer specialization. This applies to Discipline, Holy Priest, Holy Paladin, Restoration Druid, and Restoration Shaman. Mistweaver Monk and Preservation Evoker already had this functionality.

Druid magic dispel

Resto druid gets the Nature's Cure talent which allows them to remove magic effects from allies in Cataclysm pre-patch but as far as I can tell Decursive does not support this. I attempted to go into the settings to tell it to track magic but the square was "greyed out" and can't be selected. Using most current version of addon I can find.

[Classic] 2.7.8-8-g455eb5a-classic fatal error

Mirroring this from the curseforge issue tracker.

https://www.curseforge.com/wow/addons/decursive/issues/195

Does not work on classic

Tried to run this on WoW Classic and the addon is too new for the classic servers

	if (auraTYPE_failTYPE == SPELL_FAILED_LINE_OF_SIGHT or auraTYPE_failTYPE == SPELL_FAILED_BAD_TARGETS) then

	if not self.profile.DoNot_Blacklist_Prio_List or not self:IsInPriorList(self.Status.Unit_Array_UnitToGUID[self.Status.ClickedMF.CurrUnit]) then
	self.Status.Blacklisted_Array[self.Status.ClickedMF.CurrUnit] = self.profile.CureBlacklist;

	self:Debug("\|cFFFF0000XXXXX\|r \|cFF11FF11Updating color of blacklist frame\|r");
	self:ScheduleDelayedCall("Dcr_Update"..self.Status.ClickedMF.CurrUnit, self.Status.ClickedMF.UpdateSkippingSetBuf, self.profile.DebuffsFrameRefreshRate, self.Status.ClickedMF);
	end

	self:SafePlaySoundFile(DC.FailedSound);
	--[=[
	elseif auraTYPE_failTYPE == SPELL_FAILED_BAD_IMPLICIT_TARGETS then
	self:AddDebugText("ERR_GENERIC_NO_TARGET", "Unit:", self.Status.ClickedMF.CurrUnit, "UE:", UnitExists(self.Status.ClickedMF.CurrUnit), "UiF:", UnitIsFriend("player",self.Status.ClickedMF.CurrUnit), "CBEs:", timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, spellID, spellNAME, _spellSCHOOL, auraTYPE_failTYPE); --]=]
	end