1uphealth / fhir-react Goto Github PK

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

• Set up jest and react-testing-library in fihr-react.
• Add a few example tests.
• Run the tests during CircleCI build.

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Device component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Binary component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Goal component
• Add fixtures, tests, storybook stories

• Update this issue as issues are found

TODO:

• Add STU3 support to FamilyMemberHistory component
• Add fixtures, tests, storybook stories

should allow any fhir resource to be inserted and display using the correct compoenent based on resourceType

WIP list of components:

• Observation

TODO:

Add STU3 support to Immunization component
Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

• Set up eslint & prettier for fihr-react.
• Add lint and lint:fix tasks to package.json that will check and automatically fix code formatting.
• Fix the formatting and lint violations of the entire codebase.
• Add the lint step to CircleCI build, so it will fail when code is malformed.

Recommended eslint config: see what create-react-app uses https://www.npmjs.com/package/eslint-config-react-app
https://www.npmjs.com/package/eslint-config-prettier
https://www.npmjs.com/package/eslint-plugin-prettier

Example .eslintrc config:

{
  "extends": [
    "react-app",
    "prettier"
  ],
  "plugins": [
    "prettier"
  ],
  "rules": {
    "semi": "error",
    "prettier/prettier": "error",
  }
}

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

I noticed the current size of fhir-react package is ~430KB (uncompressed).
This is way too big for a reusable package.

AFAICT, the main culprits are:

• lodash package, which is being imported in entirety, even though we use only a few utilities.
• crypto package, also imported whole even though we just use the MD5 hash function.

TODO:

• Replace lodash imports with imports of individual utilities, e.g. lodash/get.
  Bonus: make sure lodash is never imported whole, for example using https://www.npmjs.com/package/babel-plugin-transform-imports.
• Find a more lightweight alternative for crypto package.

TODO:

• Add STU3 support to Encounter component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to DiagnosticReport component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

Add STU3 support to MedicationStatement component
Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Build storybook to a static bundle on CircleCI (on master branch)
• Deploy the bundle to a public URL (e.g. AWS S3, GitHub pages etc...)

TODO:

• Add STU3 support to AllergyIntolerance component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Migrate the MedicationOrder resource component
• Migrate the Generic resource component

• Remove superfluous dependencies.
• Add scripts field for common tasks (lint, test, build).

https://circleci.com/gh/1uphealth/fhir-react

• CircleCI should be able to pull the code of fihr-react and run tasks (future tasks for lint and tests) on every pull request and master branch.
• Add integration with GitHub so the build statuses would show on Pull Requests.
• Add CircleCI status badge to the Readme. https://circleci.com/docs/2.0/status-badges/

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

Add STU3 support to Practitioner component
Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Encounter component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to CarePlan component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Condition component
• Add fixtures, tests, storybook stories

TODO:

• Add STU3 support to Practitioner component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

TODO:

• Create scaffold of component
• Add DSTU2 support to component
• Add STU3 support to component
• Add fixtures, tests, storybook stories

The current state of styling in fhir-react is a mix of inline styles and bootstrap.
It is not very readable, a bit inconsistent and not extensible by users.

Here's our idea to improve the architecture:

• Consistency: write regular CSS files for styles, instead of inline/bootstrap combo.
• Extensibility: use BEM-style class names e.g. .fhir-ui__Value, fhir-resource__Observation. Consumers will be able to override these classes with their own styles.
• Lessen the dependency on bootstrap (avoid using its classes and utilities).

TODO:

• Style components in src/components/ui
• Style components in src/components/resources
• Style components in src/components/container
• Style components in src/components/datatypes
• Optional: export one stylesheet for consumers to import (e.g. via webpack)

TODO:

• Create scaffold of the component
• Add STU3 support to component
• Add fixtures, tests, storybook stories