Giter Club home page Giter Club logo

tidal-lyrics's People

Contributors

1nikolas avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

tidal-lyrics's Issues

Scroll to and highlight current line.

Hi,

Most of the Lyrics on Musixmatch has timing information about each line. Musixmatch uses this in their own apps to automatically scroll to the current line and highlight it clearly.

It would be awesome if this could be implemented in Tidal Lyrics. It really helps a lot not having to scan the lyrics to find the right spot, only to soon realize that it was not actually the right spot, just another similar part of the song. Not having to scroll time and time again is also very nice. No one really wants to go to the computer and start messing with the mouse when singing along :)

Popup: JavaScript error popup: at endReadableNT (_stream_readable.js:1187:12)

I've seen the below popup a couple of times now.
Last time the window did not update lyrics after that until I restarted the app.
Not sure if that always happens though. I don't remember needing to restart the app before.

[Window Title]
Error

[Main Instruction]
A JavaScript error occurred in the main process

[Content]
Uncaught Exception:
SyntaxError: Unexpected token
in JSON at position 16
    at JSON.parse (<anonymous>)
    at Request._callback (C:\Users\magnu\AppData\Local\tidal_lyrics\resources\app\src\index.js:331:34)
    at Request.self.callback (C:\Users\magnu\AppData\Local\tidal_lyrics\resources\app\node_modules\request\request.js:185:22)
    at Request.emit (events.js:310:20)
    at Request.<anonymous> (C:\Users\magnu\AppData\Local\tidal_lyrics\resources\app\node_modules\request\request.js:1154:10)
    at Request.emit (events.js:310:20)
    at IncomingMessage.<anonymous> (C:\Users\magnu\AppData\Local\tidal_lyrics\resources\app\node_modules\request\request.js:1076:12)
    at Object.onceWrapper (events.js:416:28)
    at IncomingMessage.emit (events.js:322:22)
    at endReadableNT (_stream_readable.js:1187:12)

Handle parenthesized title postfix comments

Many of the songs on Tidal have a parenthesized postfix to their title. Examples:

Title (Remastered)
Title (XXXX Remaster)
Title (Album Version)
Title (Single Version)

Tidal Lyrics usually fails to find lyrics for these songs even when they are on musixmatch without the postfix.

Suggestion: If the initial search fails and the song name has a postfix parenthesis, strip the postfix and the preceding whitespace and retry the search.

Fails to find Simon & Garfunkel lyrics even though they are on Musixmatch

Not a single Simon & Garfunkel song has worked for me so far. I looked up the last one to fail and it was on Musixmatch.

Just a guess, but might it be that tidal-lyrics fails to properly escape the '&' character and thus matching fails? Maybe some strategic spot needs a call to a UrlEscape method, or similar, to fix this for all special characters?

Tidal is Paused.

But why the lyrics are disappearing? They are not moving anywhere, anyhow so this feature is a bit annoying tbh.

When tidal is paused the tag disappears, I know but when resuming the song creates a, not a tiny, lag which causes a little distraction while practicing etc.

Not an issue but a suggestion btw.

image

Severe memory leak crashing computer

My computer just went belly up completely for the second time in a week. This time I looked into it. The first error in the chain of the total crash was this:

Windows successfully diagnosed a low virtual memory condition. The following programs consumed the most virtual memory: tidal-lyrics.exe (22328) consumed 63648477184 bytes, oracle.exe (8108) consumed 21085532160 bytes, and vmmem (25552) consumed 3110047744 bytes.

64 Gigabytes. That's a lot for a lyrics display program :)

A JavaScript error occurred in the main process Win 64bit app 1.5

imagen
i got this error when i select a song and then i get into thee loading loop.

the log just show me this.

State: Playing Nxwhere - Jenevieve
Search URL: https://www.musixmatch.com/search/Nxwhere*%20-%20Jenevieve
Search URL: https://www.musixmatch.com/search/Nxwhere*%20-%20Jenevieve/tracks
Unicode Lyrics URL: <html>
  <head>
  

thanks alot for develop this!

Frozen!

your app is freeze in my computer in initialization (Loading...).

Do you have any suggestion.

Thank in advance!

BR
Far

This content show up after installed and try to play something on Tidal

Hi There. I am using Macbook Pro with M1 here.
I installed the file completely fine and gave the permission of access.
When I play something on Tidal then it shows me this.
I am so sorry. I am a totally tech dumb dumb. This is as far as I can go.
Can you tell me what should i fix?
Thanks for your time.

Uncaught Exception:
SyntaxError: Unexpected token
in JSON at position 7
at JSON.parse ()
at Request._callback (/Applications/tidal-lyrics.app/Contents/Resources/app/src/index.js:377:34)
at Request.self.callback (/Applications/tidal-lyrics.app/Contents/Resources/app/node_modules/request/request.js:185:22)
at Request.emit (events.js:310:20)
at Request. (/Applications/tidal-lyrics.app/Contents/Resources/app/node_modules/request/request.js:1154:10)
at Request.emit (events.js:310:20)

Windows PowerShell Error.

image
I'm receiving this error when trying to use the App. I already installed the Last Version of PowerShell, but it didn't work.

Can you help me?

Songs with commas on their titles don't work.

I tried a few songs with commas on their names and they just didn't work. I don't know if this only happens to me, if it does, don't worry and close the issue.
Pd: thanks for this amazing tool!
image
image

Please make the window resizeable

Thank you so much for this app. Not having lyrics is a big minus in a music app for me ๐Ÿ‘

It would really be nice to be able to resize the window though. When I'm singing along I really don't want to have to time and time again go grab the mouse and scroll the lyrics while trying to keep track of where the current line is. I have a 4k screen so the current window only uses something like a third of the height of my monitor :)

State of tidal-lyrics

Hey everyone
About a year ago, I made this app (for myself) because I wanted to have the lyrics of the song I'm listening on Tidal and there was no other way of doing that. Open sourcing the app was just a "why not" thought and I don't regret it. It did not only help other people solving the same problem I had, it also was the first "big" open source project of mine and it helped me learn lots of stuff on managing and maintaining open source projects.

As you might have already seen, Tidal partnered with Musixmatch and now it has officially integrated synced lyrics on both the mobile and desktop app, which makes this app useless.

image

So this marks the end of tidal-lyrics' development and in a few days the repository will be archived. Of course if you want you can keep using the app but there will be no further updates and fixes.

Thanks for using my app!
Nikolas

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.