Hi! @alexeyleping

I have merged #18, but all the icons have changed to select.png. We can't load the other icons successfully. Could you please fix this?

The current:

The expected:

• assigned: @alexeyleping
• related: #18, #15

Since all the objects inherit from Shape, we can use polymorphism to store all the objects in a single shapes list, instead of separating them into shapes and lines.

private List<Shape> shapes = new ArrayList<Shape>();
// private List<Line> lines = new ArrayList<Line>(); // This can be removed

The current version of the icon is not satisfactory because we have not removed the background color. Therefore, we can enhance the UI and update the demo cover simultaneously.

• Deadline: 2024/06/14 23:59
• Demo: 2024/06/14 13:30~13:45

• #3
• #4
• #5
• #8

Plus

• #11
• #12
• #14
• #15
• #16
• #17
• #19

In the program, we need to avoid using variables as strings because we might change the names of these variables in the future. Renaming them everywhere would be time-consuming. Instead, we should use enums or an Action class for aggregation.

The below variables are not encapsulate into the class, and they are publicly accessible. This lack of encapsulation could pose a security risk.

Take BasicObject as an example, All the Shapes are inheriented from Shape which means Shape is considered as the Base class; however, some object we need to redefine the isInside maybe we could have a better method to implement this.

Separate paint method into multiple methods. Plus, we can extract this method from Canvas

Currently, we need to use 'if' statements to perform Actions. In the future, we should be able to separate Actions from Components, and also provide enum Actions for direct use, similar to the concept of STATUS_CODE.

Current Action Class:

package src.Actions;

import javax.swing.*;
import java.awt.event.*;
import src.Utils.StatusCode;

public class MenuItemAction extends JMenu implements ActionListener {
    public MenuItemAction() { }

    public void actionPerformed(ActionEvent e) {
        if (e.getActionCommand().equals("About XML Editor")) {
            aboutAction(e);
        } else if (e.getActionCommand().equals("Quit (Control + Q)")) {
            exitAction(e);
        }
    }

    private void aboutAction(ActionEvent e) {
        String message = "Hello World! This is a simple XML Editor.";
        JOptionPane.showMessageDialog(null, message);
    }

    private void exitAction(ActionEvent e) {
        System.exit(StatusCode.EXIT);
    }
}

In the code, there are some fragments of the code are unnecessary, we can remove the unused one.

Change the arrow to hollow (outline), ensuring the line does not pass through the arrow.

Take Generalization Line as an example, the current "calculation formula" containing in the draw(); however, at the first glance, we cannot identify what this calculation formula doing; therefore, we can wrap them as the function to be called by draw().

related: #11

According to the article "Why can't a Java enum be final?", the answer states, "Java does not allow you to create a class that extends an enum type. Therefore, enums themselves are always final, so using the final keyword is superfluous." Consequently, we can remove the final keyword from our enum type variables.

The meaning of i-- may result in the difficulty of maintenance in the future, we have to add some meaning of this function.