Issue with amoose/simple_form about identity-idp HOT 11 CLOSED

I bet we can probably get rid of it and use the official gem instead. @amoose do you recall what the aria-invalid branch was all about?

from identity-idp.

I replaced it with just:

gem 'simple_form'

and things basically worked fine.

from identity-idp.

😕 That is weird.

@monfresh Yes, it was 508-compliance. It adds aria-invalid attribute to fields with errors.

from identity-idp.

I just cloned my repo without issue ¯_(ツ)_/¯

We can switch to official simple_form gem for now, but I wanted to submit a 508-compliant or now a USDSWDS+508-compliant strategy for simple_form

from identity-idp.

what version of git are you running @greggersh?

from identity-idp.

It was 2.6.4/Apple Git, I just upgraded to 2.8.1 via homebrew, which did not fix it.

from identity-idp.

Greg, try running the laptop script.

from identity-idp.

@monfresh hmm, I'm probably not going to do that, and I don't think that should be a pre-req for getting an open source project running. I'm sure it's an awesome script, though. ;)

I've done some research and I think this is related to settings in my .gitconfig file related to vulnerability that came out earlier this year (January, I think?).

from identity-idp.

Yeah, that did it. I had to set the following in my ~/.gitconfig file:

[transfer]
        fsckobjects = false
[fetch]
        fsckobjects = false
[receive]
        fsckObjects = false

(they had previously been set to true because of some vulnerability, which I can't find right now)

If I understand this correctly, the only solution I've found is to do a massive recopy of the repo, which will change all the git shas and basically destroy any connection between @amoose's fork and the base simple_form repo (so, not something to do willy-nilly).

from identity-idp.

Here's a related thread: ohmyzsh/ohmyzsh#4963

from identity-idp.

Thanks for that info, @greggersh. We will point to the latest gem and toss my fork. This feature is small and can be easily integrated in to the latest version. I will create an issue to update the gem. 😎

More information about fsckObjects:

• https://geekoverdose.wordpress.com/2016/02/03/git-security-enabe-fsckobjects-in-gitconfig/

from identity-idp.