Giter Club home page Giter Club logo

Comments (5)

afeld avatar afeld commented on June 16, 2024

Also, reached out to see if the architecture motivation/overview/instructions are written down somewhere:

https://twitter.com/aidanfeldman/status/738376676619505664

from domain-scan.

konklone avatar konklone commented on June 16, 2024

Having multiple languages in a single Dockerfile is an antipattern (IMHO), and I think the setup for each scanner could be a lot simpler if you isolated each tool to its own Dockerfile.

@afeld I agree so very wholeheartedly.

cc @garrettr as well

from domain-scan.

afeld avatar afeld commented on June 16, 2024

We talked about this suggestion at length in Slack, but just wanted to give a picture of what the Dockerfiles might look like, to hopefully better demonstrate the idea/benefits:

# Dockerfile-domain-scan
FROM python:3
CMD glue-code-that-calls-docker-run-on-the-others.py

# Dockerfile-sslyze
FROM python:2
RUN wget ...
CMD sslyze

# Dockerfile-inspect
FROM ruby
RUN bundle install
CMD inspect

...

from domain-scan.

afeld avatar afeld commented on June 16, 2024

Hacked on this a bit tonight: #67

from domain-scan.

konklone avatar konklone commented on June 16, 2024

Closing as inactive.

from domain-scan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.