Giter Club home page Giter Club logo

Comments (4)

christhompson avatar christhompson commented on June 20, 2024

Quick followup: This works on 3.6rc1, as they added support for Path-like objects:

Changed in version 3.6: Accepts a path-like object.

(https://docs.python.org/3/library/os.html#os.remove)

But that doesn't work in 3.5.

Similarly for Path.resolve(strict=false) in 3.6rc1: https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve

from domain-scan.

konklone avatar konklone commented on June 20, 2024

It looks like ccf5e04 made this change without realizing the impact to Python 3.5. Thanks for reporting it.

I'm up for fixing this, but is 3.5 support important for you? I could also see us just raising the expected Python version to 3.6, since it's become relatively easy/clean to upgrade Python versions.

from domain-scan.

christhompson avatar christhompson commented on June 20, 2024

Yeah, I'd say that Python 3.5 support is not that important (it's the default python3 on my workstation but I can just opt-in to Python 3.6 for now), so the easier solution is probably to just bump the minimum version requirement to Python 3.6 in the readme.

from domain-scan.

konklone avatar konklone commented on June 20, 2024

👍 Filed #262 to do this.

from domain-scan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.