1391819 / ma-seek Goto Github PK

The documentation on this is great! I appreciate putting the work into this. I am looking to reproduce the experiments you did. It would be great if you included what versions of python dependencies you are using.

I believe these are the third party modules you are using based on looking at your source code:

• tensorflow
• keras
• numpy
• gym
• pygame

In the README, I would recommend adding a section on installation and usage

Some Other Recommendations / Suggestions

Generally, src shouldn't be used to store source code: https://docs.python-guide.org/writing/structure/
You could have a package called ma_seek and a setup.py to allow one to pip install -e ma_seek.
main.py
This would allow you to write imports like this:

...
from ma_seek import PATH
from ma_seek.maenv import MASeek
from ma_seek.drqn import DRQN
from ma_seek.replay_buffer import ReplayBuffer
...

Instead of hardcoding configuration in main.py, you can take advantage of hydra for configuration management.
See https://hydra.cc/docs/intro/

I am getting an error while running main.py .

AttributeError: '_UserObject' object has no attribute 'get_weights'