0x-r4bbit / angular-github-adapter Goto Github PK

Hi! I'm testing this adapter and it's amazing. Now I'm trying to build a simple login app using it, and once the user is logged in, list all the repositories that the user (in this case, me) has, including the privated ones.
But I don't know how to be sure if I'm successfully authenticated or when my username or password are wrong, to return a message to html. There is a way to know it?

I'm currently using the "setCreds('myUsername', 'myPassword', 'basic')" method and a service for auth purposes. The code for that method, creates a Github() instance but never returns it neither a boolean value to confirm that everything is ok or not.

Thanks in advance :)

Hi, and thanks for the adapter. I've incorporated into one of my projects and thought I would give a little feedback.

1. For some reason it wasn't quite clear to me that this actually depends on github.js. I was mistakenly under the impression that it replaced it (until I got errors and actually read the code a bit closer 😉). A couple suggestions on this:

• You're including the angular.js lib when you install this via bower, so perhaps also make github.js a dependency as well and install that alongside (which is also available through bower).
• Clearly state in the README that github.js should be installed and included in your app.

Let me know which approach you'd like to take here and I'll be happy to open a pull request.

2. The README has a slight conflict in it's instructions in that it first states to use the variable $githubProvider and then later says you can now access $github within your controller and services. Using angular.module('myApp').config(function ($githubProvider) { doesn't actually work. You get an Error: Unknown provider: $githubProviderProvider <- $githubProvider if you try. So I would suggest a change to the README for that. I'll open a pull request for you on that and try to follow your guidelines. (see #3)

Please create new release as there's new code available :)

Could you please make a new release to include the fix for listPulls. Thanks!

Could you include main field in bower.json?