Giter Club home page Giter Club logo

Comments (8)

06chaynes avatar 06chaynes commented on July 21, 2024 1

Sounds good!

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024 1

Published new versions of the crates today with the custom cache key changes, thanks for your patience on this!

from http-cache.

veeshi avatar veeshi commented on July 21, 2024 1

I've seen the cache modes added and it would be nice if that could be modified on a per request basis. The use case is we only want to cache certain content types. The idea is to to add a closure in an option which if it exists it can be used to check the request and return an updated cache mode for instances where we want to either bypass the cache or use the cache with the default rules. I'll try knocking up a PR with this.

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024 1

Looks great, just merged into develop. Thanks again for your contributions!

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024

Thanks! Glad you found it useful. I'm not against adding something like this, do you have something in mind as far as what the implementation might look like?

from http-cache.

veeshi avatar veeshi commented on July 21, 2024

For the customisable cache key I'm thinking of adding another field to CacheOptions called cache_key and it is a closure that takes the request and returns the cache key as a String.

With regards to overriding the cache options on a per request basis, I haven't dug much in to it, but the only way I can think of doing this is with a trait implemented for ClientWithMiddleware with a function which takes CacheOptions and creates a task_local_extensions::Extensions with the CacheOptions and then calls ClientWithMiddleware::execute_with_extensions with them.

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024

Think I generally understand what this might look like, would you care to provide a high level overview of the use case for this just so I understand better?

CacheOptions belongs to the http_cache_semantics crate, so we would need to add a new field HttpCache struct or maybe create a new options struct that can contain this CacheOptions, cache_key, and any possible future options.

from http-cache.

veeshi avatar veeshi commented on July 21, 2024

It's essentially a HTTP proxy which allows configuration for different routes.

Ah I didn't realise it was a re-export, just seen the note in the main http-cache crate!

I think an addition of another struct to the HttpCache struct wrapping the CacheOptions and cache_key seems ideal and future proof but it is a breaking change. I'll try to draft something up this weekend on the customisable cache_key first.

from http-cache.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.