Giter Club home page Giter Club logo

Comments (3)

06chaynes avatar 06chaynes commented on July 21, 2024 1

Just added the fix for this, for now Surf will continue to use the request url unless something can be worked out later.

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024

I'll make that change for reqwest, just an error on my part when I was moving the code over.

I didn't consider how surf middleware order may impact things but that makes sense. I'll try testing a bit with that use case.

Maybe I should wrap the url field in HttpResponse with an Option? Then surf can use None rather than the request url to help avoid confusion.

  • Maybe not on that last part, ignore that for now

from http-cache.

06chaynes avatar 06chaynes commented on July 21, 2024

Also updated the readme on surf middleware order, would still like to test more but thought it was worth adding a note

Edit: Thought about this a bit more and I think it should be ok as long as the cache is registered after the middleware handling redirection, still haven't tested though

from http-cache.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.