naxesss / mapsetverifier Goto Github PK

Concurrent hit objects. [00:12:690 (1,1)](osu://edit/00:12:690 (1,1)) - Within 7.152557009248994E-05 ms of one another.

However, the objects aren't close to concurrent in the editor (50ms apart). Other 50ms apart sliders in the map don't show this false positive.

Map is this one https://osu.ppy.sh/beatmapsets/1829583#osu/3755042

Just a simple check that will notify the mapper to check if a stack that is not actually stacked is intentional, like the ones here:

https://osu.ppy.sh/beatmapsets/2145273 - 01:16:698 (1,2,3) -

Everytime I try to download the app, it’s just stops almost halfway and says “Setup was not completed successfully.” It won’t give me a reason why

Backend doesn't want to start

 ~/D/mapsetverifier-1.8.2  ./resources/app/api/linux-x64/MapsetVerifierBackend
Startup.
Configure Services.
No usable version of libssl was found
fish: Job 1, './resources/app/api/linux-x64/M…' terminated by signal SIGABRT (Abort)

That's weird because ssl is one of the most essential libraries on every distro and of course I have them. Could it be a version issue? Because I'm on Ubuntu 22.04 LTS which was released later than the last release of this program so maybe due to updated distro packages? Hopefully this project is still being maintained.

Got this on this beatmap, but there are more than two of such snapped hitobjects

WHAT DO I DOOOOOOOOO

No idea what this means, I tried restarting computer & program but it didn't work (Win10)
It never loads the map, infinite load

Would be nice to have a Hardware Acceleration / GPU option so that it could possibly get through the map and toggle between difficulties in Checks mode

Opening overview tab of any mapset causes an error on arch linux.

A couple of maps have got ranked recently with offscreen sliders that didn't get picked up by MV, which unfortunately is a violation of the Ranking Criteria. Here's this one for example (link: https://osu.ppy.sh/beatmapsets/1699993#osu/3497827):

See? The left side of this slider is offscreen, but for whatever reason MV thought this slider wasn't.

Possibly adding features to check invalid hitsounding volumes of timing lines like? Not sure if the case applies for MV (because clicking on it will crash the osu! client) but can be useful when there are huge amount of lines in the timing panel and when people use external programs for hitsounding which can potentially cause such issues.

It keeps saying Installation Aborted every time I tried to install without any meaningful feedback. What could possibly be the problem here?

title of issue

this makes it extremely confusing to navigate through a map looking for a specific spike since you have to manually add the intro time every time you want to navigate to a potential problem point

in the example below my map has an intro time of around 5.5s and ends at the following timestamp

yet when we see it in MV it would end at around 3:04:

this replicates itself on other maps

(i have no idea where else to post this without pinging naxess directly, this is my first time using github)

bug on genre and languages. after refreshing and updating the beatmap and restarting the app, it wont see that it has genre and languages set.

When I opened any mapsets on Windows 7, there were no responses to loading.

But when I used it on Windows 10, it could work well.

It is detecting expert as lowest diff. Which doesn't make any sense.

Is it because of the hitsound diff?

https://i.imgur.com/30NNHZL.png

map with issue: https://osu.ppy.sh/beatmapsets/914868#mania/1933299

...and as a result it shows as all green even though no checks happened in the first place.

note that the set-wide checks still run as usual, but they may also be broken because of the diff name as well

When I try to use Mapset Verifier (prior to choosing a song folder,) nothing works. This persists after choosing a song folder, and I cannot run any checks.

I have no clue what's going on. I've restarted my PC, which did not help. I've tried running as administrator, and that also didn't help.

Any ideas?

Thanks.

OS: Arch Linux

App not opening whether installed from AUR or running executable from tar.gz.

Running mapsetverifier:

[grindle@CRAPPY-DESKTOP mapsetverifier-1.8.2]$ ./mapsetverifier 
Fontconfig warning: "/usr/share/fontconfig/conf.avail/05-reset-dirs-sample.conf", line 6: unknown element "reset-dirs"
[6318:0908/191300.075107:FATAL:gpu_data_manager_impl_private.cc(892)] The display compositor is frequently crashing. Goodbye.
Trace/breakpoint trap (core dumped)
[grindle@CRAPPY-DESKTOP mapsetverifier-1.8.2]$

Running mapsetverifier --no-sandbox gets the app to open, but backend seems to not work as beatmaps get stuck infinitely loading.

Running MapsetVerifierBackend:

[grindle@CRAPPY-DESKTOP linux-x64]$ ./MapsetVerifierBackend
Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.
   at System.Environment.FailFast(System.String)
   at System.Globalization.GlobalizationMode.GetGlobalizationInvariantMode()
   at System.Globalization.GlobalizationMode..cctor()
   at System.Globalization.CultureData.CreateCultureWithInvariantData()
   at System.Globalization.CultureData.get_Invariant()
   at System.Globalization.CultureInfo..cctor()
   at System.Globalization.CultureInfo.get_InvariantCulture()
   at MapsetVerifierBackend.Program.Main(System.String[])
Aborted (core dumped)
[grindle@CRAPPY-DESKTOP linux-x64]$ 

Running export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1; ./MapsetVerifierBackend:

[grindle@CRAPPY-DESKTOP linux-x64]$ export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1; ./MapsetVerifierBackend
Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly '/mnt/Storage Box/Executables/mapsetverifier-1.8.2/resources/app/api/linux-x64/resources/app/checks/MapsetChecks.dll'. The system cannot find the file specified.

File name: '/mnt/Storage Box/Executables/mapsetverifier-1.8.2/resources/app/api/linux-x64/resources/app/checks/MapsetChecks.dll'
   at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(IntPtr ptrNativeAssemblyLoadContext, String ilPath, String niPath, ObjectHandleOnStack retAssembly)
   at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
   at System.Reflection.Assembly.LoadFile(String path)
   at MapsetVerifierFramework.Checker.LoadCheckDLL(String aCheckPath) in D:\VSPROJECTS\Visual Studio 2017\Projects\MapsetVerifierFramework\Checker.cs:line 120
   at MapsetVerifierBackend.Program.Main(String[] args) in D:\VSPROJECTS\Visual Studio 2017\Projects\MapsetVerifierBackend\Program.cs:line 33


Aborted (core dumped)
[grindle@CRAPPY-DESKTOP linux-x64]$

Running export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1; ./mapsetverifier yields the same error as running without the export.

Finally, the app can be successfully launched as normal with export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1; ./mapsetverifier --no-sandbox, allowing beatmaps to be loaded and checked as normal.

EDIT: Actually, I just rebooted my computer and the above command is still required but all functionality works now and the errors below don't apply.

However, this method yields two errors which don't seem to affect Checks functionality i.e. Backend error, click here for details.:

Unhandled exception.

System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use. ---> Microsoft.AspNetCore.Connections.AddressInUseException: Address already in use ---> System.Net.Sockets.SocketException (98): Address already in use at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName) at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress) at System.Net.Sockets.Socket.Bind(EndPoint localEP) at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync() --- End of inner exception stack trace --- at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync() at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass21_0`1.<g__OnBind

Additionally, it seems Snapshots functionality won't work with this as it yields an error i.e. Unable to find the specified file.:

at Interop.Sys.GetCwdHelper(Byte* ptr, Int32 bufferSize) at Interop.Sys.GetCwd() at System.IO.Path.GetFullPath(String path) at System.IO.File.GetCreationTimeUtc(String path) at MapsetSnapshotter.Snapshotter.SnapshotBeatmapSet(BeatmapSet aBeatmapSet) in D:\VSPROJECTS\Visual Studio 2017\Projects\MapsetSnapshotter\Snapshotter.cs:line 57 at MapsetVerifierBackend.Server.Worker.RequestSnapshots(String aBeatmapSetPath) in D:\VSPROJECTS\Visual Studio 2017\Projects\MapsetVerifierBackend\Server\Worker.cs:line 137

Mapset Verifier doesnt seem to treat skin files as used ones since the file still shows up as unused in MV

this is what mv shows and this is what my metadata is. i think the suggestion that should be displayed should be

"nightcore" in tags, consider "(Nightcore Mix)" instead of "(Sped Up Ver.)" in romanized title.

instead of the other way around since i already have "(Sped Up Ver.)" in the title

Extra rows of icon are found.

It should be like this :

Random ranked map

Random loved map

Besides, when I click any icons in my map, the app freezes and crashes.

If you need my map to test here's the link : https://osu.ppy.sh/beatmapsets/1398887#osu/3016977

kinda minor thing but can you detect if preview time is snapped or not.

sometimes after audio change, cause offset shift and mapper forget to shift the preview by like 5-10ms

some mapper are perfectionist and will self DQ for this change:
https://osu.ppy.sh/beatmapsets/1696523/discussion/-/generalAll#/3141891

would be nice to add if not too much trouble.
can use warning, not problem, could be intentional unsnapped.

as seen on https://osu.ppy.sh/beatmapsets/1102714/discussion/-/generalAll#/1411859
should be self-explanatory

Reference map: https://osu.ppy.sh/b/1877799
Has drum hitnormal every measure.
Its worth mentioning if the density is high, but for something like an easy, it shouldnt be an issue.

Normal Sliders Have CurvePoints Like 113,85,11274,6,0,P|151:85|201:121,1,80, but Invisible Notes / Sliders Without CurvePoints Looks Like 146,189,13070,2,0,L,1,47.9999985351563, And It Does not Detect.
Slider Syntax Looks like x,y,time,type,hitSound,curveType|curvePoints,slides,length,edgeSounds,edgeSets,hitSample, but having no curvePoints set it goes invisible (not in osu!lazer)

I'm new to linux and is using ubuntu 20.04 LTS
I searched on google about installing tar.gz files
But I followed the tutorial and it gives me an error of like "config, no such directory" or "INSTALL, no such file" etc

Summary:
I've got my osu! folder on external HDD and setting up the folder in-app to the Songs folder on my external HDD doesn't populate the maplist

Repro Rate:
Mapset Verifier 1.8.2 on 21H1 (19043.1348) - 5/5

Repro Steps:

1. Install the app
2. Make sure your osu! folder is on an External HDD
3. Select a Songs folder in-app
4. Observe the issue as the maplist doesn't populate

Expected Results:
Maplist populates and user is able to pick a map from it

Actual Results:
Maplist doesn't populate with maps

In MV it says the audio bitrate is 196kbps

In Spek it says audio bitrate is 192kbps

I converted the original flac file to ogg with this FFmpeg command:
ffmpeg -i input.flac -map_metadata -1 -c:a libvorbis -b:a 192k audio.ogg

I assume that MV is wrong since 2 other apps says the ogg file is 192kbps.

My mapset for reference : https://osu.ppy.sh/beatmapsets/1706338#osu/3506931

i just got unsnapped error in mapset verifer, but not AiMod, and plus, ranked diff have same error too. Here is some screenshot: https://puu.sh/Id2FE/45437ca947.jpg
and this is for ranked mapset : https://puu.sh/Id2Gz/a20863cfbc.jpg | https://puu.sh/Id2Hf/e3329331f0.jpg

Infinite load on Win10
MapsetVerifierBackend do nothing when running it

One difficulty has slightly offset timing to the others, as I was in the process of applying mods and haven't updated one of the difficulties as it's a gd and adjusting offset makes applying mods inconvenient.

https://drive.google.com/file/d/1EjkkYaCMPXD6FEmERAVJeeIAMWh4SSqu/view?usp=sharing
Exported .osz of the mapset in question

new RC

...have an average bit rate no greater than 192 kbps for .mp3 files, or 208 kbps for .ogg files.

currently your program throwing error for 193 kpbs for ogg still

Here are some issues found out during testing on Linux.
OS: Manjaro Linux

• Upon update
  • resources/app-update.yml currently isn't bundled with the installer, rendering any update attempts to be failed.
  • latest-linux.yml is missing from all releases, making a 404 Not Found upon update (It should have been generated beforehand, though.) Image
• Application
  • appdataPath goes to ~/.local/share/Mapset Verifier Externals while the folder is created on ~/.config/Mapset Verifier Externals, this not only makes settings isnt viable, but also opening external folder impossible.

For last point, it seems to be caused by the fact that MapsetVerifierBackend is not consistent with Mapset Verifier's appdataPath.

On MVBackend, it uses Environment.SpecialFolder.ApplicationData that points out to ~/.config, while Environment.SpecialFolder.LocalApplicationData points out to ~/.local/share^[1]

^[1] https://jimrich.sk/environment-specialfolder-on-windows-linux-and-os-x/

I noticed while fixing 1 ms unsnaps (moving the objects in question back by 1ms), if they had a green line on them it'd give the "Hit object is unaffected by a line very close to it." warning even though the line was also moved. Similarly, moving a green line forward 1ms so that it no longer affected the object it was placed on would fail to cause this error. Restarting the program fixes this, but swapping to a different map and then back does not.

happens only with one map
this error was not present before

As the title says, to encounter this bug, simply start a kiai (whether from a red or green line it doesn't matter), then add a red line and a green line on the same tick whilst in the current kiai. I discovered this when my kiai calculation was different for nearly every difficulty due to a nightcore red line (metronome reset) I added. Offsetting the green line by as little as +-1ms seems to fix this but I'd rather get this addressed in MV rather than have to offset my maps.
Kiai Time in MV, almost every difficulty is different:

The red and green line that seems to be causing the issue:

By offsetting the green line by 1ms in every difficulty it magically fixes itself (I also did the note it affected but this did not change the results):

How to reproduce:

1. have a timeline like this
   
2. put a slider after 1:28:000
3. save beatmap
4. run mapset verifier with negligible issues shown

And it will claim the inherited line at 1:28:000 "changes SV, but affects nothing", when it does affect the SV of the slider created in 2).
After some experiments I think this issue only affects the last inherited line.

The samplerate of the audio file of some featured artists' songs is too high. I think it gets compressed when uploading or it doesn't matter for ranking.

when I filter hybrid to taiko-only sets, Verifier can't catch reversearrow.png ( i think this object is not used in taiko) maybe is this a bug or smth?

On this map: https://osu.ppy.sh/beatmapsets/1216983#osu/2532174

Verifier reports the drain time as being ~4:13, when in reality it's something like 4:17. I think it's not counting the spinner at 01:23:731 (1) - somehow.

When I expand the first backend error I get the follow message:

System.IO.IOException: Failed to bind to address http://127.0.0.1:5000: address already in use. ---> Microsoft.AspNetCore.Connections.AddressInUseException: Only one usage of each socket address (protocol/network address/port) is normally permitted. ---> System.Net.Sockets.SocketException (10048): Only one usage of each socket address (protocol/network address/port) is normally permitted. at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName) at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress) at System.Net.Sockets.Socket.Bind(EndPoint localEP) at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync() --- End of inner exception stack trace --- at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync() at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass21_0`1.<g__OnBind

The second backend error returns the following message:
Unhandled exception.

The only real context I can give is this issue popped up after I replaced my GPU with an Intel GPU (Intel Arc A750). I have no idea if that could've caused the issue or something else I touched in the like 12 hour span since the last time I launched MV and this issue cropped up.