amirno1 / hyf-javascript1 Goto Github PK

Hi Amir,
Very nice homework.
I would just be careful in the Arrays.js exercise:

• giving the first array the name "Arrays" is a bit dangerous. It is very close to Array, which is the actual Array data type. And generally, starting a variable with a capital is reserved for class definitions (something you will get into more as we go along). It is plural which is good, but generally you name the array on its contents; as you have done with the animals after that.
  Checking variables.js
• small point, I would add a space at the end of the lines defining the types, and maybe add a colon so the output looks more like this:
  "The type of age is number: number"
  rather than:
  The type of age is numbernumber
• Also, when showing the types that are not equal, it might be an idea to include the values you are comparing

Other than those small points, really nice neat and readable work that works! 👍 Nicely done.

Hi Amir, here is my feedback on your homework for week 3.

Overall this looks pretty good.

1-more.js

Correct!

2-more.js

Correct!

You can combine the spaces in the corresponding string literals:

return "a " + color + " car";

3-more.js

Correct!

4-more.js

Although it produces the correct results, I think you overlooked this part of the instruction:

Your function should return a string,

So rather than using console.log inside the function body, return the result as a string and console.log the result when you call the function. This will make your function pure and free of side effects: the most desirable form for a function.

5-more.js

Correct!

6-more.js

See my comment on 4.

7-more.js

It would be best to move the array inside the function body and remove the console.log statement from the function body. This would make the function pure and without side effects.

8-more.js

Correct! But make your function pure and without side effects.

See my slack message for alternative implementations.

9-more.js

Correct! See my comment for 8 above.

10-more.js

Correct!

11-more.js

Using a metaphor: x and y are like twin brothers, they look the same but are separate entities. However, z is just another name for x.

12-more.js

Apply the same reasoning as for 11 above.

13-more.js

This was explained by Tamir in class.

Hi Amir,
The only thing I have to say is really nice work.
Everything works as specified, and the code is (again) very nicely laid out and readable.

Well done!