Giter Club home page Giter Club logo

Comments (6)

zxpsuper avatar zxpsuper commented on September 2, 2024 2

Hello,

I'm using your (great) package version 1.0.5 in a Laravel project. My assets are bundled using Vite. After building my assets for prod, I have an error "require is not defined" in my console. I tracked down the error to this code:

// import QRCode from "qrcode"
var QRCode = require("qrcode");

in lib/qrcode-with-logos.esm.js

When editing directly this file in my node_modules and using the commented import, it works just fine.

I checked in the repo and there is a pull request #15 that mentions this.

Is this something I can somehow fix on my part or should it be changed in the npm package?

Thank you for looking into this!

I will fix it in next version. The fastest way to solve this problem is that copying qrcode-with-logos.esm.js file to your project and fix it .
Editing directly this file in your node_modules is not a Reliable way.

from qrcode-with-logos.

magror avatar magror commented on September 2, 2024

Hello, That updated version would be much appreciated! Is there an ETA? Thank you very much in advance :)

from qrcode-with-logos.

HoekWax avatar HoekWax commented on September 2, 2024

Hello @zxpsuper, same question as above, do you have an ETA for this ? Thanks

from qrcode-with-logos.

j-d-carmichael avatar j-d-carmichael commented on September 2, 2024

This package is perfect for what I am looking for... but I am also hitting the same issue as above.

Any timeline on the new release?

from qrcode-with-logos.

j-d-carmichael avatar j-d-carmichael commented on September 2, 2024

Forked and PR created: #33

from qrcode-with-logos.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.