Declaration file required for Typescript about tribute HOT 11 CLOSED

I don't use Typescript, so any help or direction on this would be much appreciated. This would be a great addition. Thanks!

from tribute.

any update on this? :)

from tribute.

@BorntraegerMarc Thanks for checking in! I'm not quite sure how to write a typing but it doesn't seem too complicated. I can take a stab at it.

from tribute.

Thanks. Let me know if you need help

from tribute.

Since TypeScript 1.8, it's allowed to include .js files with --allowJs flag.
See https://blogs.msdn.microsoft.com/typescript/2016/01/28/announcing-typescript-1-8-beta/

Set "compilerOptions": { "allowJs": true },
depending on your project structure include tribute library: "include": ["node_modules/tributejs/dist/tribute.js"],
now you can use Tribute, just add import {default as Tribute} from 'tributejs/dist/tribute';

from tribute.

Yes @TetianaP but it would be cool to have some definitely typed support for codin :)

from tribute.

@TetianaP @BorntraegerMarc I've added a PR that adds a typings file to the project. Let me know if I need to make any changes! #59

from tribute.

@mrsweaters left my comments in the PR. Thx!

from tribute.

Merged! #59

from tribute.

Sorry to come back at you this late but wouldn't it make more sense to publish the typings here https://github.com/DefinitelyTyped/DefinitelyTyped ?

I thought this would be standard practice...

from tribute.

@BorntraegerMarc Ah, good call. I'll be sure to add this to the DefinitelyTyped repo.

from tribute.