Giter Club home page Giter Club logo

Comments (5)

ztgrace avatar ztgrace commented on August 15, 2024

Hey @anshumanbh,

I was just thinking about a similar feature where you could specify --ssl as an argument to force it to SSL.

For your use case, are you seeing services that in one version have SSL and in another version don't have it? What I want to be careful about is adding extra requests and unnecessarily slowing down scans.

If I were to implement the both feature, I'd likely try the SSL version first, then the non-SSL. That way it "prefers" the encrypted connection and then I could catch the requests.exceptions.SSLError as a way to handle the non-SSL call.

from changeme.

anshumanbh avatar anshumanbh commented on August 15, 2024

yeah, I encountered two open consoles yesterday. One was over http and the other one was over https (with an invalid SSL cert configured that was throwing errors).

Typing something like ./changeme --protocols http --portoverride $HOST:$PORT didn't work for both the hosts even though the $PORT was 80 for the first one and 443 for the second one.

When the ssl value in the YML was false, the above command worked for the http host. And, when the ssl value in the YML was true, it worked for the https host. So, I had to create two YML files with ssl value true and ssl value false.

And I am sure there are plenty of usecases like these where we are possibly missing out because of the ssl value.

I like your idea to start with ssl and then deal with non ssl if an error instead of having "both". Whatever makes sense to you really.

from changeme.

ztgrace avatar ztgrace commented on August 15, 2024

I guess I'd like to keep the cred files as close to the "default" install as possible and introduce an option to have this behavior.

from changeme.

anshumanbh avatar anshumanbh commented on August 15, 2024

sounds good! thanks and appreciate it

from changeme.

ztgrace avatar ztgrace commented on August 15, 2024

Implemented in v1.1.

from changeme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.