Comments (2)
Does this happen when loading the video? changing video in the playlist? or showing the thumbnail?
I'm using the logic thrice.
- Once to calculate the tooltip size containing the thumbnail. (Which is the location of the error)
https://github.com/Zren/mpv-osc-tethys/blob/master/osc_tethys.lua#L1810 - Again for drawing the thumbnail itself.
- PictureInPicture toggle code.
https://github.com/TheAMM/mpv_thumbnail_script/blob/master/src/thumbnailer_shared.lua#L146
It seems the the thumbnail script waits until it's ready before calling update_state()
then get_thumbnail_size()
.
local scaleX, scaleY = get_virt_scale_factor()
local videoDecParams = mp.get_property_native("video-dec-params")
local videoWidth = videoDecParams.dw
local videoHeight = videoDecParams.dh
if not (videoWidth and videoHeight) then
return
end
Since I already have a check on videoWidth and videoHeight. I might as well use one of these:
local videoDecParams = mp.get_property_native("video-dec-params", {})
local videoDecParams = mp.get_property_native("video-dec-params", {dw=0, dh=0})
or
local videoDecParams = mp.get_property_native("video-dec-params")
if videoDecParams == nil then
return
end
local videoWidth = videoDecParams.dw
local videoHeight = videoDecParams.dh
if not (videoWidth and videoHeight) then
return
end
from mpv-osc-tethys.
this happen when
changing video in the playlist
from mpv-osc-tethys.
Related Issues (20)
- seek back/forward button Not response HOT 4
- Enable Title directly above the seek bar -Request HOT 6
- `idlescreen` option to disable the logo HOT 1
- Documentation for frontends like mpv.net HOT 2
- Show Chapter List on Key Bind HOT 5
- Thumbnailing command failed! error HOT 5
- Request: Thumbfast support HOT 2
- Request: Slice longfilenames on Title HOT 4
- Picture-in-picture only strips the border HOT 4
- Removing the tooltips for buttons/controls HOT 1
- Whitebox beside thumbnail HOT 1
- Replace autoload.lua with Play Next File In Dir on Media End HOT 2
- Request: Seekbar Improvements HOT 2
- Request: Show Number of Files in a Playlist on the Title Bar HOT 2
- Missing audio track button HOT 2
- Еhumbnail preview does not work HOT 1
- How to set loop only, and not next to other videos? HOT 1
- Shared Script Properties are Deprecated
- Does not longer work with mpv 0.38. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpv-osc-tethys.