Tracing phase should surround call logging about ktor-opentracing HOT 6 OPEN

That is good to hear. We will surely upgrade on our next iteration, thanks @fstien for all the effort!

from ktor-opentracing.

Hey Hannes, Thanks for your message.
Yes so CallLogging intercepts before the monitoring phase, whereas this ktor-opentracing feature was intercepting (and creating the server span) before the features phase, which happens after the monitoring phase. Hence when you try to read the span from GlobalTracer in CallLogging, it hasn't been created yet.

I just released a change where i move back where i intercept to after the setup phase. Do you want to try again with v0.3.2 and let me know ? :)

from ktor-opentracing.

As soon as we can, thanks in advance!

from ktor-opentracing.

Hi @fstien. Thank you for this nice project, I encountered a similar issue regarding CallLogging in one of my projects. Could you let me know where I can grab the 0.3.2 or 0.3.3 version, I could run a test for you.

from ktor-opentracing.

Just to let you know that we got the 0.3.3 and it is working as expected for our project. Just something to note, the generated POM file you published doesn't include any of the transitive dependencies so we had to add the kotlin-logging-jvm dependency manually. But aside from that, all good!

Thanks you very much!

from ktor-opentracing.

hey @hannomalie , @ajcastillo301 , Thanks. I had a play around with CallLogging issue, indeed the trace cannot be read when that feature intercepts. I'm not sure why, there's clearly something about CallLogging I don't understand. 🤷‍♂️ I will leave this issue open for now.

@ajcastillo301 Thanks for bringing this up. If you try version 0.3.5 , that has the dependencies in the pom.xml ; https://repo1.maven.org/maven2/com/zopa/ktor-opentracing/0.3.5/ktor-opentracing-0.3.5.pom .

from ktor-opentracing.