Add playback buffer support to partyline module (or at least an error message) about znc HOT 6 CLOSED

I asked for this feature before, but i was told that the partyline-module/-code isn't that easy to change to achieve a bufferfunction

from znc.

If that's the case, adding some kind of error feedback when messaging offline users on the partyline would make it less of a blackhole.

from znc.

I'm rather wondering why all these issues are being referenced by Issue #94. Anyways, I would love this, either one of these solutions. I'll see if I can code an error into partyline.cpp, but I haven't been doing much coding for rather a long time, and I'm not very good at it. Another solution would be to have logged off users disappear entirely from the partyline.

Edit: try replacing lines 411-422 of partyline.cpp (starts/ends the same) with the code below. New lines are not indented. This should return a 403 numeric and a message that the user is not attached . Also, I would like to recommend that you not use the connected irc server to return the numerics, if that doesn't break rfc or clients, though I left it that way to match the other code.

           if (pUser) {
if(pUser.isUserAttached()) {
                for (vector::const_iterator i = pUser->GetNetworks().begin(); i != pUser->GetNetworks().end(); ++i) {
                    CIRCNetwork* pNetwork = *i;
                    pNetwork->PutUser(":?" + m_pUser->GetUserName() + "!" + m_pUser->GetIdent() + "@" + sHost + " " + sCmd + " " + pNetwork->GetIRCNick().GetNick() + " :" + sMessage);
                }
                for (vector::const_iterator i = pUser->GetUserClients().begin(); i != pUser->GetUserClients().end(); ++i) {
                    CClient* pClient = *i;
                    pClient->PutClient(":?" + m_pUser->GetUserName() + "!" + m_pUser->GetIdent() + "@" + sHost + " " + sCmd + " " + pClient->GetNick() + " :" + sMessage);
                }
} else {
m_pClient->PutClient(":" + GetIRCServer(m_pNetwork) + " 403 " + m_pClient->GetNick() + " " + sTarget + " :znc user: " + sNick + " is not attached.");
}
            } else {
                m_pClient->PutClient(":" + GetIRCServer(m_pNetwork) + " 403 " + m_pClient->GetNick() + " " + sTarget + " :No such znc user: " + sNick + "");
            }

from znc.

Can someone provide a link to an explanation why the it's not possible to log private messages (and therefore partylines)? What would have to be done to change that?

from znc.

Private messages do come through in the query buffer. If partyline messages should be buffered, where should this go? Which network of the users?

from znc.

I am new to ZNC so I am not shure if I understand you right. Yes, the partyline channels are on 'no network', but I dont understand why this makes a difference (i would say "just call the network 'localhost' or 'znc'" but that sounds too easy).

Basically the partyline module makes it possible to have 'internal' channels and I would like them to behave like 'normal' channels (or understand why it's not possible). The only other solution I see right now would be using an IRC server listening on localhost instead of the partyline module (which really sounds like overkill).

I just tested it again (using the version in ubuntu packages, so maybe thats an issue):

• If I reconnect to ZNC with my client, all regular channels (ie on EFnet) > buffer playback.
• If do the same with a 'partyline' channel > no buffer playback.

I am using the savebuff module (which does the playback?) plus the away module to catch private messages.

from znc.