checkinstall build of ZNC fails with warnings about "cp: preserving times for [...]: No such file or directory" about znc HOT 4 CLOSED

http://dholbert.pastebin.mozilla.org/1106632

I'm a bit new to github, so I'm not sure what the best way is to attach a patch. So I've just included one inline, as it's pretty trivial. The following patch fixes the issue for me and lets checkinstall run to completion. (I've confirmed that the generated .deb is functional, too)

EDIT: Replaced patch with a pastebin, since github's whitespace formatting seems to destroy tabs, even in 'pre' regions

Patch available here: http://dholbert.pastebin.mozilla.org/1106632

Basically, the "p" in "cp -Rp" isn't useful here -- it tells cp to preserve the user & timestamp & mode. It's counterproductive to preserve the user, though, since the source's owner might very well be a normal system-user-account, whereas we want the system-installed versions to be owned by root. Meanwhile, the timestamp isn't worth preserving, and the mode should get preserved automatically without any special request needed. (not to mention that these files don't have any special modes that need preserving)

(I'm not 100% sure what about timestamp-preservation confuses checkinstall, but I'm guessing it's something about trying to do an extra operation on the just-copied file, and getting confused because the file ended up in a checkinstall-generated temporary directory rather than at its expected location.)

from znc.

The usual way to attach a patch with github is to create your own clone of a repo, commit you changes there and then send a pull request.

from znc.

Done -- here's the pull request: #14

from znc.

Pulled that commit, thanks a lot

from znc.