Comments (5)
Failed commits will not fail the runloop; the failure will be passed back to the caller of OffsetBatch#commit
. The alternative is to bake in a Schedule
that will be used for retrying commits in the runloop, but I feel that is best delegated to the caller.
What do you think?
from zio-kafka.
That makes sense, to leave it to the caller. Might be good to add it as a recommendation in the docs somewhere, and it would be nice to have that behavior in consumeWith
.
from zio-kafka.
👍
from zio-kafka.
This was implemented in #81. Shall we close it @iravid ?
from zio-kafka.
I'll take that as a yes :)
from zio-kafka.
Related Issues (20)
- PartitionedStream hanging after stream consumption started HOT 10
- AdminClient creation: java.lang.NoSuchMethodError: java.nio.ByteBuffer.position HOT 7
- Should commitOrRetry also retry commit timeouts? HOT 1
- Slow (timeout) shutdown and rebalancing with `withRebalanceSafeCommits ` HOT 13
- `partitionsFor` method missing from `zio.kafka.producer.Producer` HOT 5
- Make consumer metric collection more configurable HOT 3
- Possible to use a Scala 3 version of embedded-kafka? HOT 3
- Add support for embedded-kafka-schema-registry to the testkit HOT 4
- Consumer not reconnecting on lost session on proxy connectivity HOT 8
- ConcurrentModificationException in the release effect HOT 2
- Partition handling with plainStream and partitionedStream HOT 4
- Partition lost not recovering, possible issue with `RunLoop` HOT 1
- Document that the consumer stream fails when
- Runaway stream when `max.poll.interval.ms` is exceeded HOT 3
- Prevent compatibility problems without increasing minor version
- Best practice for recovering a consumer ZStream after any error so messages keep getting consumed HOT 4
- FromJavaConsumer: how to synchronize access to the java consumer HOT 4
- Consumer doesn't consume after `onLost` HOT 5
- Consumer.fromJavaConsumer must fail if the passed consumer has enable.auto.commit set to `true` HOT 4
- Documentation for default auto commit behaviour is missing.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zio-kafka.