A fatal system error has occurred about legal HOT 8 CLOSED

Could you possibly look at this one Robert?

from legal.

I will try to look at it later today. I have Physical Therapy this morning.

-Robert

On Tue, Sep 6, 2011 at 8:08 AM, drak <
[email protected]>wrote:

Could you possibly look at this one Robert?

Reply to this email directly or view it on GitHub:
#3 (comment)

from legal.

Any luck?

from legal.

@philipp2 - if you have time, please look at this ticket also please.

from legal.

bump

from legal.

First, this bug is not a widespread problem. It affects only the special admin user account where uid == 2. (It would affect the guest user account, uid == 1, as well if modifications to that user account were allowed.)

This error is being generated because the validation for modifying a user account (or modifying a registration record, but that particular case should be impossible in this context) throws an exception if there is an attempt to validate a change admin/guest accounts (uid <= 2).

The same check (uid <= 2) is being performed for vetoed login validation. This is probably redundant in this particular case. The veto handler does not allow uid <= 2 to be vetoed for lack of policy acceptance. It can probably be removed for that particular case.

I am looking into the other cases to see if this check is really needed, and what the implications of removing it are. If the check can be removed safely (in other words, the code is just being too damn paranoid), then that will resolve this issue with editing the admin account.

Moreover, it is probably not necessary to even allow the editing of policy acceptance for uid == 2 (or uid <= 2), since it is always the special admin user account. I will look into seeing if that can be suppressed.

from legal.

The logic is still not correct, and the last set of commits introduced a new error.

from legal.

re-closed by 8125ca6

from legal.