Comments (6)
Doctrine2 is available in core 1.3 and does not use namespaces. IMO, converting to doctrine1 is a waste of manpower.
from legal.
The plugin uses namespaces internally when it accesses the Doctrine2 code. Doctrine1 will be a no-brainer. Legal doesn't need much.
I might skip D1 altogether anyway, and just keep things in module variables for 2.x. With the 3-4 new document types that Axel added things are getting kind of too big to stay with module variables, but 2.x could probably suffer along a while longer with them.
from legal.
Internally, yes indeed. I hadn't thought of that. Still, converting to an abandoned tech seems a waste.
from legal.
Robert, the agreement for no namespacing was only for Zikula 1.3.0. From 1.3.1 we have introduced PHP 5.3 specific code as promised. There is no point implementing for Doctrine 1.
from legal.
I tend to agree with your comment regarding implementing an abandoned tech. The issue is in order to deal with the 'reset' issue I need to add a 'last updated date/time' field to each of the document types. Without D1 that means another 6 or so modvars. It really should have gotten converted to a db-driven module a while ago--at least when the new types were added.
I suppose we could just whack in the new modvars and deal with things in module version 3.0.0 when it is converted to 1.4. I suppose the only argument for going to D1 now is to allow users of core-1.3 to add more new document types.
What do others think? D1 now and allow more new types for 2.x/core-1.3, or forget it and implement the ability with D2 in 3.x/core-1.4?
from legal.
Re @Drak 's comment... well ok, then. Any further discussion regarding this (db-driven now or later) can happen over on issue #16.
from legal.
Related Issues (20)
- register form shows links to terms of use and so on although not enabled in settings HOT 2
- Cookiebar does not work on routed pages HOT 5
- Unused file? HOT 1
- The important notice is not valid for zk1.4 HOT 2
- Enable cookie warning for EU Compliance could not be switched off
- Adding Support for Webshim and Polyfill HOT 1
- Translations not working in Zikula 1.4.0 HOT 2
- [2.0.2] Changing the settings does not work HOT 1
- the legal version shipped with 1.4.2 gives error during installation HOT 1
- Migrate to 2.0 spec
- Exception when editing a user
- Policy acceptance after initial login is not saved HOT 1
- Twig_Error_Runtime: Key "termsOfUse" does not exist as the array is empty
- not all translations are used HOT 6
- Custom URL for each language
- User-Registration: Policies should not be accepted by default
- GDPR EU regulation? HOT 11
- inlineLink twig extension - few improvements
- Policies "easy" option accepting without tickbox
- EUCookie translations missing for the Legal module
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legal.