Giter Club home page Giter Club logo

Comments (6)

KCNilssen avatar KCNilssen commented on May 30, 2024

@Mattsface What do you think, should we temporarily change the tests to "wait out" till the season starts to see if this is how the MLB api handles offseason stats requests for season or should we handle it with some code checking the date against the mlb season start and end dates when asking for season stats?

Not sure what we can really do besides just wait it out and see given the lack of public facing documentation on the api

from python-mlb-statsapi.

Mattsface avatar Mattsface commented on May 30, 2024

@KCNilssen I will explore updating the pytests to add a specific season parameter. I believe you might be on to something with the new season starting.

from python-mlb-statsapi.

KCNilssen avatar KCNilssen commented on May 30, 2024

@Mattsface I think the only thing to do at the moment is wait it out and see. I tried to find information on It and came up empty.

https://statsapi.mlb.com/api/v1/people/663728/stats?stats=season&season=2018&group=catching

Adding the season param for 2018 to see if that would change anything still results in an empty return. I think this issue must be with season stats?
Issues could be:

  • They are updating season stats and have chosen this for the mean time?
  • Season stats are broken on api side
  • They have completely changed the endpoint and the way we get stats

from python-mlb-statsapi.

Mattsface avatar Mattsface commented on May 30, 2024

@Mattsface I think the only thing to do at the moment is wait it out and see. I tried to find information on It and came up empty.

https://statsapi.mlb.com/api/v1/people/663728/stats?stats=season&season=2018&group=catching

Adding the season param for 2018 to see if that would change anything still results in an empty return. I think this issue must be with season stats? Issues could be:

  • They are updating season stats and have chosen this for the mean time?
  • Season stats are broken on api side
  • They have completely changed the endpoint and the way we get stats

Let's give it a few days to see how things work out. I wish we had some information from the MLB on this.

from python-mlb-statsapi.

Mattsface avatar Mattsface commented on May 30, 2024

PR Made. I added the season param to all stat tests.

from python-mlb-statsapi.

KCNilssen avatar KCNilssen commented on May 30, 2024

Resolved with PR that includes a specified season for season stats to use to avoid the offseason mlb stats returning empty values.

from python-mlb-statsapi.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.