Giter Club home page Giter Club logo

Comments (5)

larsnystrom avatar larsnystrom commented on July 26, 2024 1

I understand it's the decision you've made, but I still think it's the wrong one. It's not just that I wouldn't mind if you installed dependencies I didn't need, it's that I would actually prefer it to the alternative (which is manual dependency management).

However, I also think the better option is to move the validators into components of their own.

On 27 maj 2016 18:47 +0200, [email protected], wrote:

Regardless of whether or not you feel the decision is "correct", it is the decision we've made. Since all validators are opt -in, installing the dependencies required for all validators is a disservice to those using a subset of them. If you're already using Doctrine, you'd likely be upset if this component also installed zend-db!

The other option we have is to move any validators with additional dependencies into their own components, which is something we may do in the future. For now, we are declaring the bare minimum dependencies required to use the component, and marking anything else as a suggestion.


You are receiving this because you authored the thread.
Reply to this email directly,view it on GitHub(#83 (comment)), ormute the thread(https://github.com/notifications/unsubscribe/AA9DskBctllybcKqAuhVG4OTe6Z9qOR9ks5qFyAigaJpZM4Ioo_a).

from zend-validator.

michalbundyra avatar michalbundyra commented on July 26, 2024 1

Maybe in suggest section (in composer.json) should be said that zend-math component is required by the Csrf validator (as it for other suggestions)

from zend-validator.

Maks3w avatar Maks3w commented on July 26, 2024

However when you are not using Csrf you don't need that dependecy.

We are aware of this kind of issues related with optional dependencies. We have choice to require as less dependencies as we can and delegate to the developer the task of require the optional dependencies he/she needs.

from zend-validator.

larsnystrom avatar larsnystrom commented on July 26, 2024

I think that is the wrong decision because it defeats the purpose of a dependency manager like composer. If you want people to manage dependencies manually you should probably not have a package.json at all.

from zend-validator.

weierophinney avatar weierophinney commented on July 26, 2024

Regardless of whether or not you feel the decision is "correct", it is the decision we've made. Since all validators are opt -in, installing the dependencies required for all validators is a disservice to those using a subset of them. If you're already using Doctrine, you'd likely be upset if this component also installed zend-db!

The other option we have is to move any validators with additional dependencies into their own components, which is something we may do in the future. For now, we are declaring the bare minimum dependencies required to use the component, and marking anything else as a suggestion.

from zend-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.