[RFC] Replace Input with a chain of callbacks. about zend-inputfilter HOT 7 OPEN

In which context do you want to create and execute the chain. I think this could lead to heavy objects, because there are so much dependencies (Hydrator, Validator, Filter, ...).

And in my opinion the code is really hard to read.

But aside of this, it could be a great feature.

from zend-inputfilter.

Chain can be created from static methods and added to input filters

$inputFilter->addInput("input name", Chain $chain);
$result = $inputFilter->resolve($inputValuesArray);

$result->isValid();
$result->getValues();

About the code legibility this is as easy as use local vars or refactor dependent components for be API compatible.

$removeWhitespaces = ...;
$validateIsFormattedAsADate = ...;

$chain
  ->then($removeWhitespaces)
  ->then($validateIsFormattedAsADate)
  ->then(null, $setFallbackValue)
;

About the dependencies, there is no dependencies, just callables.

from zend-inputfilter.

Note this way of make chains could replace or remove ValidatorChain and FilterChain classes

from zend-inputfilter.

while I like the idea of replacing *Chain classes with pipes of callbacks, I'm not keen on using A+ promises terminology for something that is not async at all. It may be confusing for people not familiar with such concepts, and it feels like mixing apples and oranges.

from zend-inputfilter.

Well, who said this things could not be async in the future or with alternative PHP engines.

from zend-inputfilter.

If that was the actual intention, I'd rather have the input filter wrapped in a promise via a dedicated implementation like reactphp/promise, or introduce a new zend component for that purpose, but then again... why would you do that?
A promise-like interface has many aspects that are not that useful in this particular case, all you want to do is just pass an array through a stack of callbacks... Why not rethink the current Chain class to be more generic and simple instead, and avoid the design overhead of things like a "fake-promise" resolution and rejection?

from zend-inputfilter.

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at laminas/laminas-inputfilter#6.

from zend-inputfilter.