NotEmpty validator doesn't override the required attribute about zend-inputfilter HOT 10 CLOSED

We had the same issue that 'Value is required' message can not be localized to Chinese as it is hardcoded in the framework code. The custom-message NotEmpty validator cannot override this error message like this case. Please help to make the hardcoded message localizable.

from zend-inputfilter.

@tflin please open a new issue

from zend-inputfilter.

@larsnystrom I don't understand what do you refer about override required attribute. I can say the second commit of #25 will make the messages consistent using the message of test 2

from zend-inputfilter.

@Maks3w I think he speaks about this

from zend-inputfilter.

I've created a repo to make it easier to reproduce the bug.

git clone https://github.com/larsnystrom/zend-inputfilter-ticket14
composer install
php test.php

I haven't tested PR #25, I'll do that if I ever get the time.

from zend-inputfilter.

@larsnystrom We've never had setting a NotEmpty validator toggle the required flag; the only correlation between the two is that in past versions, setting the required flag to true would implicitly add a NotEmpty validator. We've changed that logic recently, however (we now check for absence of a value when the required flag is true, and invalidate earlier when that condition arises). Is it possible that's the issue you're seeing?

from zend-inputfilter.

@weierophinney If you look at the MyFilter::init() method in the test code above, you'll see that I've set required to true and also added a NotEmpty validator to both input specifications in the InputFilter. Then, if a field is empty, the NotEmpty validator should run and fail, right? As you yourself wrote in #11

The solution to #11 is to keep the input as required, but to inject your own NotEmpty validator at the top of the chain yourself; Input will detect that it's present, and not inject its own NotEmpty validator.

So, the solution is:

• Keep the input required
• Inject your own NotEmpty validator with the custom message as the first validator in the chain.

That is exactly what I've done.

Now, if you look at test case 1, you'll see that this works when both fields are empty! Fantastic.

Moving on to test case 2, where only one of the fields are empty. I'd expect the corresponding NotEmpty validator to run and fail, right? That's what happened in the first test case. But (here comes the bug) the NotEmpty validator doesn't run and instead the required attribute and its associated logic takes precedence.

The behaviour is different when (1) all fields are empty and (2) only one field is empty. That's the bug.

from zend-inputfilter.

Fields on test 1 are not empty. Are not set. Value is unknown so can't be determined if value is empty or not.

from zend-inputfilter.

Please test against current master

from zend-inputfilter.

The current master solves the inconsistence, but makes it completely impossible to customize the "Value is required" message when there isn't a value. But that's discussed in other issues (#11 and #28), so I'll close this issue now.

Another issue is that the fallback value isn't validated. Personally I'd prefer if it was validated/filtered just like any other value. But that's outside the scope of this issue.

from zend-inputfilter.