Comments (5)
This appears to be related to fatih/color#132.
I can think of three solutions:
- Set
color.NoColor = false
unconditionally. However, this would mess up output resulting from piping operations. - If colorization of the output is considered a component of the output format, introduce a new value for the
--output-format
parameter. However, depending on one's needs, this might warrant a combinatorial explosion of supported values for this parameter (human-nocolor
,ci-nocolor
,sarif-nocolor
...). - If colorization is not considered a component of the output format, introduce a
--color
parameter with the valuesauto
,always
andnever
, similar to howls --color
works. This seems to me to be the most flexible solution, though it requires introducing a new optional parameter.
from kube-score.
Hej @Sebelino! 👋
Hmmmm, that's annoying, I would have expected faith/color to be smarter here. I think that I like option 3 the best, maybe in some sort of combination with automatic detection if we're running inside GitHub Actions.
from kube-score.
I've pushed a hacky fix with auto coloring support that enables color support by default when running on GitHub Actions. Are you building from source, or should I make a new release so that you can test it?
from kube-score.
Hoy, that was quick! I built it from source and it works beautifully now. Didn't even have to supply the --color
flag, although it's still a nice-to-have feature.
Thanks!
from kube-score.
No problem! :-)
from kube-score.
Related Issues (20)
- Add flag --run-test strings HOT 8
- Documentation on the use of livenessProbe
- Gatekeeper policy compatibility HOT 2
- Facing an issue in kube-score code HOT 1
- Can we set rules to ignore init-Container HOT 2
- API for easier embedding into other applications
- Helm chart is reporting a missing PodDisruptionBudget when replicas count is not defined HOT 2
- Ignoring rule container-resources makes every rule exceptional HOT 4
- Support sidecarContainers HOT 1
- ignore-test test pods HOT 4
- lack of awareness for ResourceQuota for ephemeral-storage check HOT 2
- SARIF output is not valid HOT 4
- Add check for replicas > 1 HOT 1
- Add check for update strategy HOT 1
- Check "deployment-replicas" should consider minReplicas in HPA configuration HOT 2
- --enable-optional-test for container-memory-requests-equal-limits does not enable test HOT 2
- Namespace validation should be ignored if is not defined HOT 5
- Please fix optional check for seccomp
- Add support for checking Capabilities set when using PSA/PSS restricted
- `Error: exec format error` for any `score` command HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kube-score.